Skip to content

Breaking change in 6.1.4 - error one findByIdAndUpdate with undefined id #11149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomgrossman opened this issue Dec 28, 2021 · 0 comments
Closed

Breaking change in 6.1.4 - error one findByIdAndUpdate with undefined id #11149

tomgrossman opened this issue Dec 28, 2021 · 0 comments
Assignees
@vkarpov15
Labels
discussion If you have any thoughts or comments on this issue, please share them!
Milestone
6.1.6

Comments

@tomgrossman
Copy link

tomgrossman commented Dec 28, 2021 •
edited
Loading

Do you want to request a feature or report a bug?
bug

What is the current behavior?

In the latest release, there is a "fix":

fix(update): throw error when calling findByIdAndUpdate with undefined id #11079

While I understand the logic behind it, it is a breaking change in the version.

What is the expected behavior?
As the previous ~6.1 versions, no errors, just don't update any document.

What are the versions of Node.js, Mongoose and MongoDB you are using? Note that "latest" is not a version.
Node.js - 16
Mongoose: 6.1.4
@IslandRhythms IslandRhythms added the discussion If you have any thoughts or comments on this issue, please share them! label Dec 28, 2021
@vkarpov15 vkarpov15 added this to the 6.1.6 milestone Jan 3, 2022
@vkarpov15 vkarpov15 mentioned this issue Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkarpov15 vkarpov15

Labels
discussion If you have any thoughts or comments on this issue, please share them!
Projects
None yet
Milestone
6.1.6
Development

No branches or pull requests
3 participants
@vkarpov15 @tomgrossman @IslandRhythms