Investigate bluebird for promises

[pspeter3]

Bluebird seems to have the strongest performance benchmarks for promises and seems to match the coming DOM Promises in V8 the closest. I'm wondering if it is a good choice for the interim as a Promises/A+ implementation.

[benjamingr]

+1 for this

[refack]

👎 prefer native promises - #1699

[benjamingr]

@refack why? They're slower and don't do unhandled rejection detection which is one of the most important features of Bluebird, they also provide worse stack traces.

Using Bluebird would mean deleting code and removing cruft, you can remove all the promise code from there and simply do Promise.promisifyAll("mongoose"); which would generate that code on the fly.

[refack]

@benjamingr, native, because their native. They will become the standard (and improve in performance I'm sure).
I also agree with aheckmann's goal of factoring out userland functionality into other modules, and I belive your example of Promise.promisifyAll("mongoose"); answers your own question, that is no need to integrate internally, if it could cloud be solved as so simply in userland.

[drewhamlett]

+1 for Bluebird

[Globegitter]

Any update on this? Bluebird does seem like the best solution out there currently.

[klimashkin]

+1 for Bluebird

[klimashkin]

Also Bluebird have fast cute opportunity to use callback on promise: nodeify
For example:

Model.prototype.save = function save (fn) {
  return new Promise(function (resolve, reject) {
    var options = {}
    if (this.schema.options.safe) {
      options.safe = this.schema.options.safe;
    }
    ...
  }).nodeify(fn);
};

After that we will be able to call save so:

model.save()
     .spread(function (savedDoc, num){...})
     .catch(function (err){...})

and so (classic):

model.save(function (err, savedDoc, num){...})

[benjamingr]

@petkaantonov - I recall an argument about .nodeify returning a promise. I see the docs still specify that it does. Is this case in the comment above supported?

[petkaantonov]

yes it always returns the promise

[j]

+1 ooooya.

[vkarpov15]

See #2688