-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple PR that adds enforcing onto schema #9958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uhh the checks aren't relevant to the PR. |
I forgot to add this before I guess. This way, if T is a string/number/function, then it shows it as well. If it is another type, it also shows it (which is why it isn't any).
vkarpov15
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is very clever. Thanks 👍
vkarpov15
added a commit
that referenced
this pull request
Feb 23, 2021
This was referenced Mar 5, 2021
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this, when creating a new schema using typescript, you get enforcing for built in types. Solves issue #9946. I know I mentioned I wouldn't create a PR but I kinda got impatient aha.
It's really annoying to not have auto complete on IDEs when writing strings, but with this bad boy of a PR, it prioritizes the built in types, so this way
SchemaDefinition<T>
doesn't affect anythingExamples