-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(header-bidding): ensure sizes for creative placeholders #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fix the error, and the empty
checks look good to me! 👍
# [1.28.0-alpha.2](v1.28.0-alpha.1...v1.28.0-alpha.2) (2022-03-08) ### Bug Fixes * **header-bidding:** ensure sizes for creative placeholders ([#325](#325)) ([fc7adc9](fc7adc9))
# [1.28.0](v1.27.0...v1.28.0) (2022-03-08) ### Bug Fixes * **header-bidding:** ensure sizes for creative placeholders ([#325](#325)) ([fc7adc9](fc7adc9)) ### Features * capitalise labels ([#318](#318)) ([c6d348b](c6d348b)) * **header-bidding:** enable user syncing through iframes for OpenX ([#317](#317)) ([a704b55](a704b55)) * **header-bidding:** multiple gam orders ([#310](#310)) ([8e4f123](8e4f123))
# [1.29.0-alpha.1](v1.28.0...v1.29.0-alpha.1) (2022-03-15) ### Bug Fixes * empty bidder unit id ([#328](#328)) ([ecc2715](ecc2715)) * **header-bidding:** ensure sizes for creative placeholders ([#325](#325)) ([c85f5b4](c85f5b4)) * use ad unit size count for determining responsive amp ads strategy ([#319](#319)) ([8578719](8578719)) ### Features * Ads providers and Broadstreet integration ([#313](#313)) ([f491b17](f491b17)) * apply custom label to ad unit block and widget ([#307](#307)) ([5a62a52](5a62a52))
🎉 This PR is included in version 1.29.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [1.29.0](v1.28.0...v1.29.0) (2022-03-22) ### Bug Fixes * empty bidder unit id ([#328](#328)) ([ecc2715](ecc2715)) * **header-bidding:** ensure sizes for creative placeholders ([#325](#325)) ([c85f5b4](c85f5b4)) * use ad unit size count for determining responsive amp ads strategy ([#319](#319)) ([8578719](8578719)) ### Features * Ads providers and Broadstreet integration ([#313](#313)) ([f491b17](f491b17)) * apply custom label to ad unit block and widget ([#307](#307)) ([5a62a52](5a62a52))
🎉 This PR is included in version 1.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
While attempting to create a header bidding GAM order without having any enabled bidder, it attempts to create without creative placeholders. This is because the creative placeholders are generated combining the accepted ad sizes from enabled bidders. This PR modifies the
get_all_sizes()
method to always return the default accepted ad sizes if no bidder sizes are found.How to test this PR
define( 'NEWSPACK_ADS_EXPERIMENTAL_BIDDERS', true );