Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle inactive newspack-popups #1056

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix: handle inactive newspack-popups #1056

merged 1 commit into from
Mar 8, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes a bug. Should be followed by a hotfix, since the bug is released on alpha.

How to test the changes in this Pull Request:

  1. Set up streamlined Donate block
  2. Deactivate newspack-popups
  3. Observe the Donate block does not fully load on the front-end

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from a team as a code owner March 3, 2022 13:53
dkoo
dkoo approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dkoo dkoo merged commit cb894b3 into master Mar 8, 2022
@dkoo dkoo deleted the fix/no-popups branch March 8, 2022 00:15
matticbot pushed a commit that referenced this pull request Mar 15, 2022
@semantic-release-bot
chore(release): 1.46.1-alpha.1 [skip ci]
00c9b8b 
## [1.46.1-alpha.1](v1.46.0...v1.46.1-alpha.1) (2022-03-15)

### Bug Fixes

* add alignment classes to iframe block ([#1050](#1050)) ([854d7cc](854d7cc))
* handle inactive newspack-popups ([#1056](#1056)) ([cb894b3](cb894b3))
* update listings class name to match after refactor ([#1064](#1064)) ([ac87922](ac87922))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.46.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Mar 22, 2022
@semantic-release-bot
chore(release): 1.46.1 [skip ci]
76face2 
## [1.46.1](v1.46.0...v1.46.1) (2022-03-22)

### Bug Fixes

* add alignment classes to iframe block ([#1050](#1050)) ([854d7cc](854d7cc))
* handle inactive newspack-popups ([#1056](#1056)) ([cb894b3](cb894b3))
* update listings class name to match after refactor ([#1064](#1064)) ([ac87922](ac87922))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.46.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adekbadek @matticbot @dkoo