Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(donate): handle woocommerce-memberships #1096

Merged
merged 2 commits into from
Apr 18, 2022
Merged

feat(donate): handle woocommerce-memberships #1096

merged 2 commits into from
Apr 18, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

See and follow instructions in Automattic/newspack-plugin#1599.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from a team as a code owner April 11, 2022 13:34
@adekbadek adekbadek mentioned this pull request Apr 14, 2022
Merged
6 tasks
miguelpeixe
miguelpeixe requested changes Apr 14, 2022
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I register with Miguel 3 Test, the customer name is the slug miguel-3-test which is not ideal:

image

Donate block while authenticated:

image

@adekbadek
Copy link
Member Author

adekbadek commented Apr 15, 2022 •
edited
Loading

Fixed in 613ed16f9c11aafcc2513bb799a9903942d0a4c6

@adekbadek adekbadek merged commit 22afbbf into master Apr 18, 2022
@adekbadek adekbadek deleted the add/handle-wc-memberships branch April 18, 2022 13:05
matticbot pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): 1.49.0-alpha.1 [skip ci]
24fdabe 
# [1.49.0-alpha.1](v1.48.0...v1.49.0-alpha.1) (2022-05-02)

### Features

* **donate:** handle woocommerce-memberships ([#1096](#1096)) ([22afbbf](22afbbf))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.49.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 3, 2022
@semantic-release-bot
chore(release): 1.49.0 [skip ci]
ae622b8 
# [1.49.0](v1.48.0...v1.49.0) (2022-05-03)

### Features

* **donate:** handle woocommerce-memberships ([#1096](#1096)) ([22afbbf](22afbbf))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adekbadek @matticbot @miguelpeixe