feat: homepage posts patterns with ad unit #1170
Conversation
|
@miguelpeixe this is great! I pushed some visual changes to make it look like more of a placeholder.
One thing I was thinking, the "Visit Plugin Page" button doesn't add much value here. It's potentially distracting the user if they click on it, losing their tab/editor just to see our Github page. Instead, would it be possible to Install/Activate the plugin directly from here? I know they would still need to setup Newspack Ads, etc... but at least they'd have the plugin already active. |
|
Thank you, @thomasguillot! It's looking so much better now!
I thought about it and the issue with Ads is not only that you currently can't just one-click install and use it inside the block editor but also that Newspack Ads depends on Newspack Plugin. We'd have to install 2 plugins on this button action and I really don't think we should. The link, which opens in a new window, at least suggests where to find the missing feature. I believe it's better than nothing, considering the one-click install is not feasible at this moment. |
|
Related, for future implementation of a one-click solution: Automattic/newspack-ads#444 |
Is there any way for us to check if Newspack Plugin is active and Newspack Ads is simply inactive? Then we should the "Activate Plugin" button. |
It is a possibility, but I'd rather tackle it separately as it also depends on Automattic/newspack-ads#444 |
src/setup/placeholder-blocks.js
Outdated
| description: __( 'Render an ad unit from your inventory.', 'newspack-blocks' ), | ||
| icon: pullquote, | ||
| message: __( 'Place ad units inside your page by installing Newspack Ads.', 'newspack-blocks' ), | ||
| url: 'https://github.com/Automattic/newspack-ads', |
There was a problem hiding this comment.
Suggestion: Github URL won't be of much use to most WP users, might be better to point to https://newspack.pub/support/advertising/
# [1.54.0-alpha.1](v1.53.1...v1.54.0-alpha.1) (2022-07-14) ### Bug Fixes * resolve merge conflict with release ([#1199](#1199)) ([ce82826](ce82826)) ### Features * **donate-block:** amounts and frequencies customisation ([#1191](#1191)) ([99d967f](99d967f)) * homepage posts patterns with ad unit ([#1170](#1170)) ([a2e652e](a2e652e)) * support new sponsor options to show authors and categories ([#1156](#1156)) ([67e8834](67e8834))
|
🎉 This PR is included in version 1.54.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [1.54.0](v1.53.1...v1.54.0) (2022-07-26) ### Bug Fixes * resolve merge conflict with release ([#1199](#1199)) ([ce82826](ce82826)) ### Features * **donate-block:** amounts and frequencies customisation ([#1191](#1191)) ([99d967f](99d967f)) * homepage posts patterns with ad unit ([#1170](#1170)) ([a2e652e](a2e652e)) * support new sponsor options to show authors and categories ([#1156](#1156)) ([67e8834](67e8834))
|
🎉 This PR is included in version 1.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Updates Homepage Posts patterns 2, 7, 14, 26 and implements new pattern 31 as described in Automattic/newspack-ads#210.
This PR also inaugurates "placeholder blocks", a simple config to allow a more descriptive missing block. The placeholder should provide an easy button to remove the missing block, a description and a link to the plugin that provides the block:
Closes Automattic/newspack-ads#210
How to test the changes in this Pull Request:
Other information: