Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure fields after floated inputs clear floats in the modal checkout #2030

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: make sure fields after floated inputs clear floats in the modal checkout #2030

merged 1 commit into from
Jan 23, 2025

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This hotfix fixes a really specific situation where the last two fields in the modal checkout are side by side, and there's a non-billing field after them. It adds a clearfix to make sure the final field doesn't end up caught on the last field.

How to test the changes in this Pull Request:

  1. Install and activate ActiveCampaign for WooCommerce and connect it to our sandbox site. By default, this will add an opt-in checkbox to the modal checkout.
  2. Under Newspack > Reader Revenue, set the modal checkout to only require the email, first and last names for checkout.
  3. Run through a test transaction with a modal checkout. I'm a little unclear when this happens, but when the email appears as the first field, you end up with this odd jumble:

CleanShot 2025-01-23 at 10 12 16

  1. Apply this PR and run npm run build.
  2. Repeat step 3 and confirm things look okay (note you may need to clear the cache to get the CSS updates, since the file size doesn't really change):

CleanShot 2025-01-23 at 10 10 59

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner January 23, 2025 18:12
@laurelfulford laurelfulford merged commit 274b4d4 into release Jan 23, 2025
10 checks passed
@laurelfulford laurelfulford deleted the hotfix/activecampaign-clearfix branch January 23, 2025 18:58
@laurelfulford
Copy link
Contributor Author

Thanks @dkoo!

matticbot pushed a commit that referenced this pull request Jan 23, 2025
@semantic-release-bot
chore(release): 4.5.6 [skip ci]
e4c327a 
## [4.5.6](v4.5.5...v4.5.6) (2025-01-23)

### Bug Fixes

* make sure fields after floated inputs clear floats in the modal checkout ([#2030](#2030)) ([274b4d4](274b4d4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.5.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

dkoo pushed a commit that referenced this pull request Feb 10, 2025
@laurelfulford @dkoo
fix: make sure fields after floated inputs clear floats in the modal …
9533ed3 
…checkout (#2030)
dkoo pushed a commit that referenced this pull request Feb 10, 2025
@semantic-release-bot @dkoo
chore(release): 4.5.6 [skip ci]
c6379e3 
## [4.5.6](v4.5.5...v4.5.6) (2025-01-23)

### Bug Fixes

* make sure fields after floated inputs clear floats in the modal checkout ([#2030](#2030)) ([274b4d4](274b4d4))
dkoo added a commit that referenced this pull request Feb 11, 2025
@dkoo @laurelfulford
@semantic-release-bot @dependabot @leogermani
fix(recaptcha): use clone of #place_order button to trigger checkout (#…
46eb8b5 
…2028)

* fix(recaptcha): use clone of #place_order button to trigger checkout

* chore: delete unwanted file

* fix(recaptcha): don't create button clone if not using v2

* fix: make sure fields after floated inputs clear floats in the modal checkout (#2030)

* chore(release): 4.5.6 [skip ci]

## [4.5.6](v4.5.5...v4.5.6) (2025-01-23)

### Bug Fixes

* make sure fields after floated inputs clear floats in the modal checkout ([#2030](#2030)) ([274b4d4](274b4d4))

* build(deps-dev): bump @testing-library/user-event from 14.6.0 to 14.6.1

Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 14.6.0 to 14.6.1.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](testing-library/user-event@v14.6...v14.6.1)

---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump lint-staged from 15.4.1 to 15.4.3

Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 15.4.1 to 15.4.3.
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v15.4.1...v15.4.3)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: return no posts for authors without term (#2033)

* fix: remove OneSignal script from the modal checkout (#2029)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Laurel <laurel.fulford@automattic.com>
Co-authored-by: matticbot <semantic-release-bot@martynus.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: leogermani <leogermani@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @dkoo