Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Background Color Behind Load More Button in Editor #374

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Remove Background Color Behind Load More Button in Editor #374

merged 1 commit into from
Feb 20, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Feb 20, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Removes background color from Load More button container in the editor.

Closes #367 .

How to test the changes in this Pull Request:

  1. Switch to master.
  2. Add Group block to a post.
  3. Set Group block background color.
  4. Add Homepage Posts block to the Group block.
  5. Toggle Load More button on.
  6. Observe background color behind the button.
  7. Branch switch to fix/load-more-button-bg-in-group-block.
  8. Refresh editor page.
  9. Observe background is removed.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-assigned this Feb 20, 2020
@jeffersonrabb jeffersonrabb added bug Something isn't working [Block] Homepage Posts labels Feb 20, 2020
@jeffersonrabb jeffersonrabb changed the title fix: remove background color behind load more button in editor. fixes… Remove Background Color Behind Load More Button in Editor Feb 20, 2020
laurelfulford
laurelfulford approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the trick! 👍

@jeffersonrabb
Copy link
Contributor Author

Thanks!

@jeffersonrabb jeffersonrabb merged commit f5758fc into master Feb 20, 2020
@jeffersonrabb jeffersonrabb deleted the fix/load-more-button-bg-in-group-block branch February 20, 2020 02:14
matticbot pushed a commit that referenced this pull request Mar 2, 2020
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
ecef122 
# 1.0.0 (2020-03-02)

### Bug Fixes

* correct 'Load more posts' German translation ([8913258](8913258))
* fix video attribute handling ([cfe96e8](cfe96e8))
* load more button - remove amp-layout container, append each new article individually. ([#375](#375)) ([efee9dc](efee9dc))
* Manual video input ([72efba4](72efba4))
* remove background color behind load more button in editor. fixes [#367](#367). ([#374](#374)) ([f5758fc](f5758fc))

### Features

* add alignment options for youtube playlist block ([11c54f2](11c54f2))
* Add campaign field to Donate block ([8268836](8268836))
* Add settings and flesh out further ([f343d99](f343d99))
* Basic video playlist block ([d66485a](d66485a))
* Get basic everything working well ([b5537c8](b5537c8))
* Make block player interactive in editor. ([d1dce97](d1dce97))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees

@jeffersonrabb jeffersonrabb

Labels
[Block] Homepage Posts bug Something isn't working released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blog Posts Block: Background colour issue around More button in Editor
3 participants
@jeffersonrabb @matticbot @laurelfulford