Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update carousel style since AMP 1.5.1 #427

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Since AMP 1.5.1 (or 1.5, I didn't check...) AMP removed a few css properties from AMP Carousel, including the left/right position of the prev/next buttons.

This PR adds some of these properties back. I also used em instead of px for placement to match the .entry-wrapper paddings.

I also restyled the bullet navigation to match the style in #382

How to test the changes in this Pull Request:

  1. Downgrade AMP to 1.4.4
  2. Add a Carousel block to a page
  3. Notice the prev/next arrows -- there is a 16px gap
  4. Upgrade AMP to latest version (currently 1.5.1)
  5. Notice the gap -- it should be gone (error!)
  6. Switch to this PR
  7. Notice the gap -- it should be back (and has increased, from 16px to 1.5em)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was able to reproduce the issue on AMP 1.5.3, and this solves it nicely. Good catch!

@thomasguillot thomasguillot merged commit 94312d2 into master Apr 17, 2020
@thomasguillot thomasguillot deleted the update/carousel-style-amp-1.5.1 branch April 17, 2020 07:35
matticbot pushed a commit that referenced this pull request Apr 21, 2020
# [1.3.0](v1.2.1...v1.3.0) (2020-04-21)

### Bug Fixes

* patterns sidebar background color ([#431](#431)) ([d2dfda3](d2dfda3))

### Features

* add 2 new subscribe patterns ([#426](#426)) ([07e8239](07e8239))
* update carousel style since amp 1.5.1 ([#427](#427)) ([94312d2](94312d2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants