Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patterns sidebar background color since Gutenberg 7.9 #431

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Fix patterns sidebar background color since Gutenberg 7.9 #431

merged 1 commit into from
Apr 20, 2020

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR removes the pattern's background color introduced with Gutenberg 7.9

How to test the changes in this Pull Request:

  1. Make sure you have the latest version of Gutenberg
  2. In a page/post try to add a new Pattern -- notice the grey background behind the list of patterns
  3. Switch to this branch
  4. Refresh -- grey background should be gone

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot added the Small PR Quick and easy PR to review label Apr 16, 2020
jeffersonrabb
jeffersonrabb approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle! Took me three tries just to see the issue 😄

@thomasguillot thomasguillot merged commit d2dfda3 into master Apr 20, 2020
@thomasguillot thomasguillot deleted the fix/patterns-sidebar-background branch April 20, 2020 13:09
matticbot pushed a commit that referenced this pull request Apr 21, 2020
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
322d6cd 
# [1.3.0](v1.2.1...v1.3.0) (2020-04-21)

### Bug Fixes

* patterns sidebar background color ([#431](#431)) ([d2dfda3](d2dfda3))

### Features

* add 2 new subscribe patterns ([#426](#426)) ([07e8239](07e8239))
* update carousel style since amp 1.5.1 ([#427](#427)) ([94312d2](94312d2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

@claudiulodro claudiulodro Awaiting requested review from claudiulodro

Assignees
No one assigned
Labels
released Small PR Quick and easy PR to review [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasguillot @matticbot @jeffersonrabb