Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage Posts Block: decode entities in categories when shown #474

Merged
merged 1 commit into from
May 15, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

When you have a category with an ampersand, it appears encoded in the editor (& rather than &). This PR wraps the category output in decodeEntities() to fix.

How to test the changes in this Pull Request:

  1. Add a category with an ampersand, and apply it to a post; publish.
  2. Add the Homepage Posts block to a page, and make sure your new post is displaying in it.
  3. Note the ampersand in the editor:

image

  1. Apply the PR and run npm run build.
  2. Confirm that the ampersand is now displaying as expected:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford
Copy link
Contributor Author

Thanks!

@laurelfulford laurelfulford merged commit 5347ba3 into master May 15, 2020
@laurelfulford laurelfulford deleted the fixes/category-html-entities branch May 15, 2020 19:24
matticbot pushed a commit that referenced this pull request May 19, 2020
# [1.6.0](v1.5.0...v1.6.0) (2020-05-19)

### Bug Fixes

* decode entities in categories when shown ([#474](#474)) ([5347ba3](5347ba3))
* decode entities in categories when shown in carousel ([#475](#475)) ([20dcfd3](20dcfd3))
* disallow 0 as post to show value ([80db497](80db497))
* initializing swiper for multiple blocks ([#476](#476)) ([f480d54](f480d54))

### Features

* add border style to group block ([#463](#463)) ([1c1f89d](1c1f89d))
* add image shape classes to the front end ([#473](#473)) ([c90df2e](c90df2e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants