Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent errors when there is no sponsor logo, link #581

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR helps make sure the block doesn't throw notices when a sponsor is missing a logo or a link.

How to test the changes in this Pull Request:

  1. Apply the PR and run npm run build.
  2. Set up a couple native sponsors; one with everything and one missing a logo/link or both.
  3. Set up a homepage posts block and a post carousel block that will display some of each.
  4. Confirm the sponsors are linked only when links are available on the front end (links are not clickable in the editor), and that logos only display when available on the front-end and in the editor.

Correct placement in post carousel:

image

image

Correct placement in homepage posts:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek merged commit e1337a2 into master Aug 26, 2020
@adekbadek adekbadek deleted the fixes/sponsor-links branch August 26, 2020 09:19
matticbot pushed a commit that referenced this pull request Aug 26, 2020
## [1.12.1-alpha.1](v1.12.0...v1.12.1-alpha.1) (2020-08-26)

### Bug Fixes

* prevent errors when there is no sponsor logo, link ([#581](#581)) ([e1337a2](e1337a2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.12.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 26, 2020
## [1.12.1](v1.12.0...v1.12.1) (2020-08-26)

### Bug Fixes

* prevent errors when there is no sponsor logo, link ([#581](#581)) ([e1337a2](e1337a2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants