Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: control to select default tab in donate block #643

Merged
merged 3 commits into from
Dec 8, 2020
Merged

feat: control to select default tab in donate block #643

merged 3 commits into from
Dec 8, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Dec 5, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Adds a control to specify the initially selected tab in the Donate block.

Screen Shot 2020-12-06 at 11 04 20 AM

Closes: #303

How to test the changes in this Pull Request:

  1. Add Donate block to a page or post. Verify Monthly is the selected tab, as it has been all along.
  2. In the block sidebar, change Default Tab. Verify the tab changes.
  3. Publish the post/page, in the frontend verify the correct tab is initially selected.
  4. Verify this flow works properly with Configure manually selected or unselected.
  5. To verify this won't break existing blocks, switch to master, create Donate blocks, then switch to this branch and verify there is no disruption.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-assigned this Dec 6, 2020
@jeffersonrabb jeffersonrabb marked this pull request as ready for review December 6, 2020 16:07
adekbadek
adekbadek approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encountered a problem with the defaultFrequency not being passed unless in manual mode. Suggested fix in d2f2bc1 (line was not part of this PR so I was not able to do that as a code-suggestion-comment)

@jeffersonrabb
Copy link
Contributor Author

Encountered a problem with the defaultFrequency not being passed unless in manual mode. Suggested fix in d2f2bc1 (line was not part of this PR so I was not able to do that as a code-suggestion-comment)

This change causes the automatic mode to break because previously-set (or default, e.g. $0) manual values will override the data from the reader revenue wizard. cd85642 should fix.

@jeffersonrabb jeffersonrabb merged commit 46c730b into master Dec 8, 2020
@jeffersonrabb jeffersonrabb deleted the add/donate-block-default-frequency-tab branch December 8, 2020 13:38
matticbot pushed a commit that referenced this pull request Dec 8, 2020
@semantic-release-bot
chore(release): 1.17.0-alpha.1 [skip ci]
638787f 
# [1.17.0-alpha.1](v1.16.0...v1.17.0-alpha.1) (2020-12-08)

### Bug Fixes

* disable paging in specific posts mode ([#640](#640)) ([9ea01e5](9ea01e5))

### Features

* control to select default tab in donate block ([#643](#643)) ([46c730b](46c730b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.17.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 9, 2020
@semantic-release-bot
chore(release): 1.17.0 [skip ci]
fa3ffa7 
# [1.17.0](v1.16.0...v1.17.0) (2020-12-09)

### Bug Fixes

* disable paging in specific posts mode ([#640](#640)) ([9ea01e5](9ea01e5))

### Features

* control to select default tab in donate block ([#643](#643)) ([46c730b](46c730b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

@dkoo dkoo Awaiting requested review from dkoo

Assignees

@jeffersonrabb jeffersonrabb

Labels
[Block] Donate released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Donate block: Change default option
3 participants
@jeffersonrabb @matticbot @adekbadek