Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitize post id arrays in includes and excludes #651

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Dec 11, 2020

All Submissions:

Changes proposed in this Pull Request:

Addresses a condition where null is included in post arrays in include or exclude parameters, leading to Invalid parameter(s): errors and block failure in the editor.

Closes #650

How to test the changes in this Pull Request:

  1. While still on master branch, grab raw markup from the affected page (https://sahanjournal.com/) and paste into a post or page in test environment.
  2. Observe multiple Invalid parameter(s): errors.
  3. Switch to this branch, observe the errors are gone.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb marked this pull request as ready for review December 11, 2020 14:37
@jeffersonrabb jeffersonrabb self-assigned this Dec 11, 2020
Copy link
Contributor

@philipjohn philipjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeffersonrabb jeffersonrabb merged commit b1b50bd into master Dec 11, 2020
@jeffersonrabb jeffersonrabb deleted the fix/null-include-exclude-errors branch December 11, 2020 19:45
matticbot pushed a commit that referenced this pull request Dec 15, 2020
## [1.17.1-alpha.1](v1.17.0...v1.17.1-alpha.1) (2020-12-15)

### Bug Fixes

* **api:** fallback to standard if post_format is false ([#649](#649)) ([77028aa](77028aa))
* respect excerpt length attribute in load more display ([#648](#648)) ([aef87ba](aef87ba))
* sanitize post id arrays in includes and excludes ([#651](#651)) ([b1b50bd](b1b50bd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.17.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 15, 2020
## [1.17.1](v1.17.0...v1.17.1) (2020-12-15)

### Bug Fixes

* **api:** fallback to standard if post_format is false ([#649](#649)) ([77028aa](77028aa))
* respect excerpt length attribute in load more display ([#648](#648)) ([aef87ba](aef87ba))
* sanitize post id arrays in includes and excludes ([#651](#651)) ([b1b50bd](b1b50bd))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.17.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Parameter Errors In Homepage Posts Block
3 participants