fix(class-newspack-blocks.php): assets meta file path for scripts #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to incorrect assets path, view and editor scripts were loading fallback dependencies. This resulted in unnecessary scripts being added to the front end as well as wrong dependencies being added for editor scripts. fix Automattic#779
dkoo
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Nice catch, @divyarajmasani! Thanks for the patch. I can confirm that the asset path looks correct now and that the blocks still function as expected on the front-end.
|
Thank you for verifying @dkoo, Do you have any visibility on when will this be merged? |
|
@divyarajmasani We'll merge this for the next release. Thanks again! |
matticbot
pushed a commit
that referenced
this pull request
Jul 19, 2021
# [1.30.0-alpha.1](v1.29.2...v1.30.0-alpha.1) (2021-07-19) ### Bug Fixes * **class-newspack-blocks.php:** fixes assets meta file path for scripts ([#780](#780)) ([a37ff23](a37ff23)), closes [#779](#779) * allow swiper to reinitialize carousel on attribute changes ([#807](#807)) ([cc9fa30](cc9fa30)) * do not initialize swiper instances if component is hidden ([#804](#804)) ([fe599e1](fe599e1)) * **carousel:** preview performance ([#803](#803)) ([e5fc989](e5fc989)) ### Features * **donate:** streamlined block option w/ Stripe ([#784](#784)) ([10bfb0b](10bfb0b))
|
🎉 This PR is included in version 1.30.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 19, 2021
# [1.30.0](v1.29.2...v1.30.0) (2021-07-19) ### Bug Fixes * remove autoload dependency from donation class ([#811](#811)) ([c37c885](c37c885)) * **class-newspack-blocks.php:** fixes assets meta file path for scripts ([#780](#780)) ([a37ff23](a37ff23)), closes [#779](#779) * allow swiper to reinitialize carousel on attribute changes ([#807](#807)) ([cc9fa30](cc9fa30)) * do not initialize swiper instances if component is hidden ([#804](#804)) ([fe599e1](fe599e1)) * **carousel:** preview performance ([#803](#803)) ([e5fc989](e5fc989)) ### Features * **donate:** streamlined block option w/ Stripe ([#784](#784)) ([10bfb0b](10bfb0b)) * **nrh:** donations handling ([#805](#805)) ([821f6db](821f6db))
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to incorrect assets path, view and editor scripts were loading fallback dependencies. This
resulted in unnecessary scripts being added to the front end as well as wrong dependencies being
added for editor scripts.
All Submissions:
Changes proposed in this Pull Request:
Closes #779.
How to test the changes in this Pull Request:
Test 1:
Test 2: ( Using debug methods )
newspack-blocks/includes/class-newspack-blocks.php
Line 44 in d8dd2a9
$script_data['dependencies']has the values defined in correspondingdist/{script-path}.assets.php