Post Carousel: correct path to placeholder image #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
I was able to identify that the image is now being loaded correctly, although it does not fix #788.
Here's a video of my page flickering with the loaded image:
Gravacao.de.Tela.2021-07-07.as.11.17.43.mov
This was tested with Chrome 91.0.4472.114
|
Thanks @miguelpeixe!
Dang, I knew that fix seemed too easy! :) Thank you for confirming that for me! |
matticbot
pushed a commit
that referenced
this pull request
Jul 13, 2021
## [1.29.2-alpha.1](v1.29.1...v1.29.2-alpha.1) (2021-07-13) ### Bug Fixes * correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47)) * height of post carousel blocks in editor preview ([fc69708](fc69708)) * make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1)) * override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
|
🎉 This PR is included in version 1.29.2-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 13, 2021
## [1.29.2](v1.29.1...v1.29.2) (2021-07-13) ### Bug Fixes * correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47)) * height of post carousel blocks in editor preview ([fc69708](fc69708)) * make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1)) * override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
|
🎉 This PR is included in version 1.29.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In the utils.js file, there are placeholder images listed; the 'large' and 'uncropped' images were both referencing a size (1024x683) that didn't actually exist in the assets directory.
This image was being used by the Post Carousel block in the preview under Appearance > Widgets and in the Customizer.
This seems to close #788 for me, but I'm not 100% sure if that's just because that issue was a bit intermittent. Would appreciate another set of eyes on that, to make sure it has actually stopped!
How to test the changes in this Pull Request:
npm run build.Other information: