Post Carousel: Tweak image width styles to not affect avatars #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkoo I've specifically requested your review because I noticed you added these styles -- I want to make sure they're not serving some purpose for the avatars that I'm missing. Thanks! |
dkoo
approved these changes
Jul 8, 2021
|
Thanks Derrick! |
matticbot
pushed a commit
that referenced
this pull request
Jul 13, 2021
## [1.29.2-alpha.1](v1.29.1...v1.29.2-alpha.1) (2021-07-13) ### Bug Fixes * correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47)) * height of post carousel blocks in editor preview ([fc69708](fc69708)) * make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1)) * override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
|
🎉 This PR is included in version 1.29.2-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 13, 2021
## [1.29.2](v1.29.1...v1.29.2) (2021-07-13) ### Bug Fixes * correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47)) * height of post carousel blocks in editor preview ([fc69708](fc69708)) * make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1)) * override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
|
🎉 This PR is included in version 1.29.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR makes some image sizing styles in the Post Carousel block more specific, so they're only picked up by the post thumbnail, and not the avatar.
I noticed the styles are fine when the block is out of the box, but when I try to scale down the avatar for the new widget spaces in WordPress 5.8, the avatar placement gets a bit weird (it's not perfectly square; it can overlap the byline).
How to test the changes in this Pull Request:
npm run build.left: 8pxpositioning).Other information: