-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override the default :after content from swiper #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
Thanks @glendaviesnz! Looks good to me, too. |
@laurelfulford what is the process for getting this change onto Atomic and simple sites these days - do we still need to pull it into an ETK release? |
@glendaviesnz that's still the process, yes! The most recent documentation is here: pamTN9-2pn-p2 We've been testing with the WordPress 5.8 RC, and fixing other issues in the blocks related to that; we're hoping to time the next sync close to the 5.8 release date so it can include as many of those fixes as possible. Will that work for this issue? |
Yes, we have a temporary patch in place in Jetpack, so no panic to get this fix in. |
## [1.29.2-alpha.1](v1.29.1...v1.29.2-alpha.1) (2021-07-13) ### Bug Fixes * correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47)) * height of post carousel blocks in editor preview ([fc69708](fc69708)) * make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1)) * override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
🎉 This PR is included in version 1.29.2-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.29.2](v1.29.1...v1.29.2) (2021-07-13) ### Bug Fixes * correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47)) * height of post carousel blocks in editor preview ([fc69708](fc69708)) * make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1)) * override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
🎉 This PR is included in version 1.29.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes proposed in this Pull Request:
Closes #793
How to test the changes in this Pull Request:
projects/plugins/jetpack/modules/carousel/jetpack-carousel.css
Before:
![Screen Shot 2021-07-08 at 9 39 40 AM](https://user-images.githubusercontent.com/3629020/124833236-febead00-dfd1-11eb-8038-84a58010ed9e.png)
After:
![Screen Shot 2021-07-08 at 9 39 57 AM](https://user-images.githubusercontent.com/3629020/124833251-03836100-dfd2-11eb-94aa-6151319aa2e8.png)