Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the default :after content from swiper #794

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

glendaviesnz
Copy link
Contributor

Changes proposed in this Pull Request:

Closes #793

How to test the changes in this Pull Request:

  1. Run Newspack blocks with the latest Jetpack
  2. Comment out the temporary Newspack fix from top of projects/plugins/jetpack/modules/carousel/jetpack-carousel.css
  3. Turn on the Jetpack gallery carousel option
  4. Add a Newpack Post Carousel block and a gallery block to a post, on editor and frontend notice additional next and previous buttons

Before:
Screen Shot 2021-07-08 at 9 39 40 AM

After:
Screen Shot 2021-07-08 at 9 39 57 AM

@apeatling apeatling self-requested a review July 8, 2021 20:17
Copy link
Member

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@laurelfulford
Copy link
Contributor

Thanks @glendaviesnz! Looks good to me, too.

@laurelfulford laurelfulford merged commit 2e4e735 into master Jul 9, 2021
@laurelfulford laurelfulford deleted the fix/carousel-css-overrides branch July 9, 2021 00:35
@glendaviesnz
Copy link
Contributor Author

@laurelfulford what is the process for getting this change onto Atomic and simple sites these days - do we still need to pull it into an ETK release?

@laurelfulford
Copy link
Contributor

@glendaviesnz that's still the process, yes! The most recent documentation is here: pamTN9-2pn-p2

We've been testing with the WordPress 5.8 RC, and fixing other issues in the blocks related to that; we're hoping to time the next sync close to the 5.8 release date so it can include as many of those fixes as possible. Will that work for this issue?

@glendaviesnz
Copy link
Contributor Author

we're hoping to time the next sync close to the 5.8 release date so it can include as many of those fixes as possible. Will that work for this issue?

Yes, we have a temporary patch in place in Jetpack, so no panic to get this fix in.

matticbot pushed a commit that referenced this pull request Jul 13, 2021
## [1.29.2-alpha.1](v1.29.1...v1.29.2-alpha.1) (2021-07-13)

### Bug Fixes

* correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47))
* height of post carousel blocks in editor preview ([fc69708](fc69708))
* make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1))
* override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.29.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 13, 2021
## [1.29.2](v1.29.1...v1.29.2) (2021-07-13)

### Bug Fixes

* correct path to placeholder image ([#791](#791)) ([e4f1e47](e4f1e47))
* height of post carousel blocks in editor preview ([fc69708](fc69708))
* make carousel slide image width styles more specific ([#792](#792)) ([9cc4bd1](9cc4bd1))
* override the default carousel arrows from swiper ([#794](#794)) ([2e4e735](2e4e735))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.29.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post carousel - default swiper next and previous button css is not overridden
4 participants