fix: allow swiper to reinitialize carousel on attribute changes #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
approved these changes
Jul 19, 2021
matticbot
pushed a commit
that referenced
this pull request
Jul 19, 2021
# [1.30.0-alpha.1](v1.29.2...v1.30.0-alpha.1) (2021-07-19) ### Bug Fixes * **class-newspack-blocks.php:** fixes assets meta file path for scripts ([#780](#780)) ([a37ff23](a37ff23)), closes [#779](#779) * allow swiper to reinitialize carousel on attribute changes ([#807](#807)) ([cc9fa30](cc9fa30)) * do not initialize swiper instances if component is hidden ([#804](#804)) ([fe599e1](fe599e1)) * **carousel:** preview performance ([#803](#803)) ([e5fc989](e5fc989)) ### Features * **donate:** streamlined block option w/ Stripe ([#784](#784)) ([10bfb0b](10bfb0b))
|
🎉 This PR is included in version 1.30.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 19, 2021
# [1.30.0](v1.29.2...v1.30.0) (2021-07-19) ### Bug Fixes * remove autoload dependency from donation class ([#811](#811)) ([c37c885](c37c885)) * **class-newspack-blocks.php:** fixes assets meta file path for scripts ([#780](#780)) ([a37ff23](a37ff23)), closes [#779](#779) * allow swiper to reinitialize carousel on attribute changes ([#807](#807)) ([cc9fa30](cc9fa30)) * do not initialize swiper instances if component is hidden ([#804](#804)) ([fe599e1](fe599e1)) * **carousel:** preview performance ([#803](#803)) ([e5fc989](e5fc989)) ### Features * **donate:** streamlined block option w/ Stripe ([#784](#784)) ([10bfb0b](10bfb0b)) * **nrh:** donations handling ([#805](#805)) ([821f6db](821f6db))
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Allow SwiperJS to reinitialize carousels when block attributes are updated that affect the carousel's visual rendering. Fixes a regression introduced in #804.
How to test the changes in this Pull Request:
master, add a Post Carousel block to post or page content. Observe that the carousel functions in the editor preview as expected.Other information: