Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add wptexturize to the article subtitle #910

Merged
merged 1 commit into from
Nov 17, 2021
Merged

fix: add wptexturize to the article subtitle #910

merged 1 commit into from
Nov 17, 2021

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds wptexturize to the article subtitle.

See Automattic/newspack-theme#1570

How to test the changes in this Pull Request:

  1. Add a subtitle to a post; make sure to include a quote or apostrophe, or --.
  2. Add a homepage posts block that includes that article, and set the Article Subtitle to be visible in the right sidebar.
  3. View the block on the front-end -- in the subtitle, the quotes/apostrophes will be straight up-and-down, and your -- will look like -- (when it's normally transformed to a proper m-dash when added through the post editor).
  4. Apply the PR.
  5. Refresh the page with the homepage posts block; you should now have smartquotes, and/or a proper m-dash (—).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team November 16, 2021 19:17
@laurelfulford
Copy link
Contributor Author

Thanks Adam!

@laurelfulford laurelfulford merged commit 1bec09c into master Nov 17, 2021
@laurelfulford laurelfulford deleted the fix/add-wptexturize-subtitle branch November 17, 2021 17:38
matticbot pushed a commit that referenced this pull request Nov 18, 2021
@semantic-release-bot
chore(release): 1.42.2-alpha.1 [skip ci]
5940501 
## [1.42.2-alpha.1](v1.42.1...v1.42.2-alpha.1) (2021-11-18)

### Bug Fixes

* add wptexturize to the article subtitle ([#910](#910)) ([1bec09c](1bec09c))
* update newspack-components dep version ([#923](#923)) ([7678c75](7678c75))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.42.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 30, 2021
@semantic-release-bot
chore(release): 1.42.2 [skip ci]
bfe6303 
## [1.42.2](v1.42.1...v1.42.2) (2021-11-30)

### Bug Fixes

* add wptexturize to the article subtitle ([#910](#910)) ([1bec09c](1bec09c))
* update newspack-components dep version ([#923](#923)) ([7678c75](7678c75))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.42.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @adekbadek