Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Newsletter To Post #171

Closed
jeffersonrabb opened this issue Apr 29, 2020 · 12 comments · Fixed by #272
Closed

Convert Newsletter To Post #171

jeffersonrabb opened this issue Apr 29, 2020 · 12 comments · Fixed by #272
Assignees

Comments

@jeffersonrabb
Copy link
Contributor

A Newspack customer recently asked whether it was possible to convert a Newsletter to a normal Post, so that Newsletter content could be fully integrated into the site. This could be useful for a site section such as a Newsletter Archive. This seems like it should be relatively easy since the Newsletter is already a post, but how would we approach the UI for this?

cc: @thomasguillot

@jeffersonrabb jeffersonrabb added the enhancement New feature or request label Apr 29, 2020
@thomasguillot
Copy link
Contributor

Screenshot 2020-04-30 at 12 47 03

What do you think of adding the functionality where we list all the newsletters?

Clicking the button would take the user to the Post Editor and copy all the blocks from the Newsletter. They can then add tags, categories, etc...

@sonjaleix
Copy link

sonjaleix commented May 5, 2020

Hi Newspack team, I'd like to weigh in on this for the Newspack client who requested this feature.

Clicking the button would take the user to the Post Editor and copy all the blocks from the Newsletter. They can then add tags, categories, etc...

@thomasguillot do you mean that there is a way to click one button and the content of the newsletter would be automatically copied into a new post? Or would the copy/pasting happen manually?

@thomasguillot
Copy link
Contributor

@thomasguillot do you mean that there is a way to click one button and the content of the newsletter would be automatically copied into a new post?

@sonjaleix yes, that's the idea 😊

Kapture 2020-05-06 at 17 26 33

@Retrofitterdk
Copy link

Retrofitterdk commented May 14, 2020

Copying a newsletter to a regular post seems a cumbersome way to create a newsletter archive, while also duplicating the content, so it exists twice in the database.

Is there any reason, why you couldn’t just add filters to the register_post_type function, so developers could set ’public’ and ’has_archive’ to true.

This would also make it easier to style newsletters (on the site) differently than regular posts.

@sonjaleix
Copy link

I agree with @Retrofitterdk in regards to the duplicate content and it being easier to style the newsletter different on the site from regular posts.

Ideally there would be a UI option to set the newsletters to 'private' or 'private' for this feature.

@jeffersonrabb
Copy link
Contributor Author

Related: #214

@sonjaleix
Copy link

Checking in to see if there might be any progress on this feature soon?

@dkoo
Copy link
Contributor

dkoo commented Jul 20, 2020

@sonjaleix I've been working on this here: #272

@dkoo
Copy link
Contributor

dkoo commented Aug 18, 2020

@sonjaleix This has been merged as of today and should be going out as part of this week's release.

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dkoo
Copy link
Contributor

dkoo commented Aug 20, 2020

@sonjaleix This is now being deployed to production sites. Just to note, you may need to flush permalinks for the new public posts to be visible (go to Settings > Permalinks and click "Save" without making any changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants