Mailchimp: PHP notices

[dkoo]

Seeing the following PHP notices on a fresh install of the latest Newspack plugin + Newsletters.

Notice: Accessing static property Newspack_Newsletters_Mailchimp_Controller::$service_provider as non static in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider-controller.php on line 28
Notice: Accessing static property Newspack_Newsletters_Mailchimp::$controller as non static in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider.php on line 42
Notice: Accessing static property Newspack_Newsletters_Mailchimp::$controller as non static in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider.php on line 42
Notice: Accessing static property Newspack_Newsletters_Mailchimp::$controller as non static in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider.php on line 43
Warning: Cannot modify header information - headers already sent by (output started at /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider-controller.php:28) in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-includes/functions.php on line 6221
Warning: Cannot modify header information - headers already sent by (output started at /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider-controller.php:28) in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-admin/includes/misc.php on line 1282
Warning: Cannot modify header information - headers already sent by (output started at /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider-controller.php:28) in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-admin/admin-header.php on line 9
Warning: Cannot modify header information - headers already sent by (output started at /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider-controller.php:28) in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-includes/option.php on line 961
Warning: Cannot modify header information - headers already sent by (output started at /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-content/plugins/newspack-newsletters/includes/service-providers/class-newspack-newsletters-service-provider-controller.php:28) in /srv/users/user2400f8f8/apps/user2400f8f8/public/wp-includes/option.php on line 962

[jeffersonrabb]

This is reproducible on Jurassic Ninja instances. The warnings will be seen in the browser. Was able to resolve by changing $service_provider and $controller to non-static class properties in https://github.com/Automattic/newspack-newsletters/blob/master/includes/service-providers/class-newspack-newsletters-service-provider-controller.php#L20 and
https://github.com/Automattic/newspack-newsletters/blob/master/includes/service-providers/class-newspack-newsletters-service-provider.php#L22.

[matticbot]

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀