Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview text option #276

Merged
merged 5 commits into from
Aug 4, 2020
Merged

Add preview text option #276

merged 5 commits into from
Aug 4, 2020

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #275.

How to test the changes in this Pull Request:

  1. Create a new newsletter
  2. Observe a new field in Newsletter section of the sidebar - "Preview text"
  3. Fill in the preview text, update it by clicking the button below
  4. Send a test newsletter – observe the preview text displayed in the email client
  5. Send the campaign – observe the preview text displayed in the email client
  6. Create a newsletter without a preview – observe no preview in the email client

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested review from jeffersonrabb and dkoo and removed request for jeffersonrabb July 29, 2020 18:54
jeffersonrabb
jeffersonrabb suggested changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After editing the Preview Text field and clicking Update preview text the Newsletter panel goes into the Retrieving Mailchimp data state and seems to remain there for an unusually long time (this from testing on a Jurassic Ninja instance, not a local environment). In addition to the potential bug of getting stuck in that state, the updating approach differs from Name/Email which can be updated without causing the Newsletter panel to reload.

Also, should the field be a TextareaControl?

@adekbadek
Copy link
Member Author

Fixed the reloading issue and updated field component in 86bea6c

@adekbadek adekbadek requested a review from jeffersonrabb July 31, 2020 14:26
dkoo
dkoo approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, and can confirm that the UI now matches updating sender name/email.

@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Aug 3, 2020
@adekbadek adekbadek merged commit 3ea6b30 into master Aug 4, 2020
@adekbadek adekbadek deleted the add/preview-text branch August 4, 2020 13:25
matticbot pushed a commit that referenced this pull request Aug 4, 2020
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
479aae6 
# [1.7.0](v1.6.0...v1.7.0) (2020-08-04)

### Features

* add infrastructure for constant contact support ([f08ee75](f08ee75))
* add preview text option ([#276](#276)) ([3ea6b30](3ea6b30))
* **ads:** handle setting ad position ([#260](#260)) ([7ad92dc](7ad92dc)), closes [#237](#237)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

@jeffersonrabb jeffersonrabb Awaiting requested review from jeffersonrabb

Assignees
No one assigned
Labels
released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support For Preview Text
4 participants
@adekbadek @matticbot @jeffersonrabb @dkoo