Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hex value for group background colors in default layouts #292

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Aug 13, 2020

All Submissions:

Changes proposed in this Pull Request:

Fixes an additional issue with Group Block background color. Three of the four default layouts use very-light-gray as their background. This color option is no longer available, so the blocks have no background color when rendered to email markup. This PR replaces them with the hex color #f0f0f0.

How to test the changes in this Pull Request:

  1. On master, create Newsletters with the "Breaking News," "Daily/Weekly (no image)," or "Daily/Weekly" default layouts.
  2. Send a test email, observe the Group block backgrounds are not present in the email.
  3. Switch to this branch and repeat.
  4. Observe the backgrounds are present in the email.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb merged commit 4cc9b84 into master Aug 13, 2020
@jeffersonrabb jeffersonrabb deleted the fix/default-layouts-group-background-color branch August 13, 2020 14:18
matticbot pushed a commit that referenced this pull request Aug 13, 2020
## [1.8.1](v1.8.0...v1.8.1) (2020-08-13)

### Bug Fixes

* group block background color ([56b96ea](56b96ea))
* use hex value for group background colors in default layouts ([#292](#292)) ([4cc9b84](4cc9b84))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants