Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce padding between elements in newsletter emails #308

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Reduce padding between elements in newsletter emails #308

merged 1 commit into from
Aug 24, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Originally, the newsletters added 20px padding around each element, which means there's typically 40px between things like paragraphs in the newsletters. This feels like a bit too much -- for comparison, the theme has 32px between elements, and the fonts are larger, so it's less space relative to how large the fonts are.

This PR reduces the padding to 12px, leaving a 24px gap between elements, which feels like it fits a bit more.

Closes #281.

How to test the changes in this Pull Request:

  1. Draft up an email, using one of the pre-made layouts, so you have a good variety of elements. Send a test email to yourself.
  2. View the email in the editor, and your email client, and note the spacing:

Editor:
image

Email:
image

  1. Apply the PR and run npm run build.
  2. Refresh the editor and send a new fresh test email; confirm that the spacing has been reduced for both:

Editor:
image

Email:
image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-requested a review August 24, 2020 21:26
jeffersonrabb
jeffersonrabb approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@laurelfulford
Copy link
Contributor Author

Thanks Jeff!

@laurelfulford laurelfulford merged commit 4806e76 into master Aug 24, 2020
@laurelfulford laurelfulford deleted the fixes/281-reduce-padding branch August 24, 2020 21:54
matticbot pushed a commit that referenced this pull request Aug 25, 2020
@semantic-release-bot
chore(release): 1.10.0-alpha.1 [skip ci]
fd52321 
# [1.10.0-alpha.1](v1.9.0...v1.10.0-alpha.1) (2020-08-25)

### Bug Fixes

* reduce padding between elements in newsletter emails ([#308](#308)) ([4806e76](4806e76))

### Features

* update icon ([#303](#303)) ([53d91f0](53d91f0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.10.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 25, 2020
@semantic-release-bot
chore(release): 1.10.0 [skip ci]
0dce7a7 
# [1.10.0](v1.9.0...v1.10.0) (2020-08-25)

### Bug Fixes

* reduce padding between elements in newsletter emails ([#308](#308)) ([4806e76](4806e76))

### Features

* update icon ([#303](#303)) ([53d91f0](53d91f0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

@thomasguillot thomasguillot Awaiting requested review from thomasguillot

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce space between elements
3 participants
@laurelfulford @matticbot @jeffersonrabb