Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic links fail to authenticate on emails with plus sign #1832

Closed
miguelpeixe opened this issue Aug 2, 2022 · 3 comments · Fixed by #1833
Closed

Magic links fail to authenticate on emails with plus sign #1832

miguelpeixe opened this issue Aug 2, 2022 · 3 comments · Fixed by #1833
Assignees
@miguelpeixe
Labels
Reader Activation released on @alpha released [Type] Bug Incorrect behavior or functionality

Comments

@miguelpeixe
Copy link
Member

Registering with an email with the plus sign (john+doe@test.com) does not allow you to use magic links as they always fail with:

image

Steps to reproduce

  1. With reader activation on, register an account with an email containing +
  2. Log out, send a magic link
  3. Try to use the link and confirm the error
@miguelpeixe miguelpeixe added [Type] Bug Incorrect behavior or functionality Reader Activation labels Aug 2, 2022
@miguelpeixe miguelpeixe self-assigned this Aug 2, 2022
@miguelpeixe miguelpeixe mentioned this issue Aug 2, 2022
Merged
6 tasks
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.88.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.89.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.89.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelpeixe miguelpeixe

Labels
Reader Activation released on @alpha released [Type] Bug Incorrect behavior or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(magic-links): fix email encoding on sent link Automattic/newspack-plugin
2 participants
@miguelpeixe @matticbot