Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader Activation: Google sign-in button race condition #1845

Closed
dkoo opened this issue Aug 3, 2022 · 4 comments · Fixed by #1846
Closed

Reader Activation: Google sign-in button race condition #1845

dkoo opened this issue Aug 3, 2022 · 4 comments · Fixed by #1846
Assignees
@miguelpeixe
Labels
released on @alpha released [Type] Bug Incorrect behavior or functionality

Comments

@dkoo
Copy link
Contributor

dkoo commented Aug 3, 2022

Describe the bug

#1781 has a race condition that results in the "Sign in with Google" button sometimes being inoperable due to the required global not existing by the time the button is rendered. This is still replicable on the current master.

To Reproduce

Steps to reproduce the behavior:

  1. On a site with Reader Activation enabled and a valid Google connection, set up a Register block in a prompt or in post content.
  2. Refresh the page several times and observe that occasionally, but button remains disabled and unclickable.
@dkoo dkoo added the [Type] Bug Incorrect behavior or functionality label Aug 3, 2022
@miguelpeixe
Copy link
Member

miguelpeixe commented Aug 3, 2022 •
edited
Loading

This is not reproducible without AMP, only on AMP with AMP Plus.

Actually it just happened less often by chance, it does happen without AMP

@miguelpeixe miguelpeixe mentioned this issue Aug 3, 2022
Merged
6 tasks
@miguelpeixe miguelpeixe self-assigned this Aug 3, 2022
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.88.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.89.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.89.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelpeixe miguelpeixe

Labels
released on @alpha released [Type] Bug Incorrect behavior or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(reader-activation): remove async prop from library Automattic/newspack-plugin
3 participants
@miguelpeixe @dkoo @matticbot