Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont try to get orders if Woo is not active #3649

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: dont try to get orders if Woo is not active #3649

merged 1 commit into from
Dec 23, 2024

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Dec 23, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Avoids an error when the job is executed while Woo is not active

How to test the changes in this Pull Request:

  1. Read the code
  2. on trunk run wp newspack detect-order-duplicates confirm it works
  3. wp plugin deactivate woocommerce
  4. Run again and confirm you see an error
  5. Checkout this branch and confirm there are no errors
  6. reactivate woo and confirm it works

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 23, 2024
@leogermani leogermani self-assigned this Dec 23, 2024
@leogermani leogermani requested a review from a team as a code owner December 23, 2024 20:08
miguelpeixe
miguelpeixe approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 23, 2024
@leogermani leogermani merged commit 608f017 into release Dec 23, 2024
10 checks passed
@miguelpeixe miguelpeixe deleted the hotfix/error-on-duplicate-orders branch December 23, 2024 20:27
matticbot pushed a commit that referenced this pull request Dec 23, 2024
@semantic-release-bot
chore(release): 5.10.4 [skip ci]
75baf11 
## [5.10.4](v5.10.3...v5.10.4) (2024-12-23)

### Bug Fixes

* dont try to get orders if Woo is not active ([#3649](#3649)) ([608f017](608f017))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.10.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

Assignees

@leogermani leogermani

Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @miguelpeixe