Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ad styles more consistent #1700

Open
laurelfulford opened this issue Feb 4, 2022 · 0 comments
Open

Make ad styles more consistent #1700

laurelfulford opened this issue Feb 4, 2022 · 0 comments
Assignees
@laurelfulford
Labels
[Type] Enhancement Improved behavior or functionality

Comments

@laurelfulford
Copy link
Contributor

This came up in #1699:

The ad colour styles are a bit odd, as they're adding some non-colour styles to the inc/color-patterns.php file, and this is making it a bit confusing to standardize spacing across ad units when they do and do not have a custom background colour.

It would be nice to move these styles all to one location in the Sass instead (minus the custom colour logic of course!).
@laurelfulford laurelfulford added the [Type] Enhancement Improved behavior or functionality label Feb 4, 2022
@laurelfulford laurelfulford self-assigned this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurelfulford laurelfulford

Labels
[Type] Enhancement Improved behavior or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurelfulford