Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Menu: Make sure mobile menu exists in AMP fallback #1805

Open
laurelfulford opened this issue May 17, 2022 · 0 comments
Open

Mobile Menu: Make sure mobile menu exists in AMP fallback #1805

laurelfulford opened this issue May 17, 2022 · 0 comments
Assignees
@laurelfulford
Labels
[Type] Enhancement Improved behavior or functionality

Comments

@laurelfulford
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now the AMP fallback JS expects the mobile menu markup to exist; while this is the case for our use of the theme, it makes things a bit fragile if the theme files are modified by others using the theme.

Describe the solution you'd like
Add a check to the JS for the mobile menu before "expecting" it to be there, so you don't get a JavaScript error.
@laurelfulford laurelfulford added the [Type] Enhancement Improved behavior or functionality label May 17, 2022
@laurelfulford laurelfulford self-assigned this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurelfulford laurelfulford

Labels
[Type] Enhancement Improved behavior or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurelfulford