Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add specific css for subscribe pattern 5 and 6 #2305

Merged
merged 2 commits into from
May 28, 2024
Merged

feat: add specific css for subscribe pattern 5 and 6 #2305

merged 2 commits into from
May 28, 2024

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented May 23, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

If you apply Automattic/newspack-blocks#1745 you'll notice that if you use Pattern 5, there isn't a gap between the intro and the form or, if you insert Pattern 6, there's a gap between the image and the card. This PR fixes both issues.

How to test the changes in this Pull Request:

  1. Checkout feat: improve subscribe patterns and use new style variation newspack-blocks#1745
  2. Insert Pattern 5 and Pattern 6 to a page
  3. Notice the issues
  4. Switch to this branch
  5. Refresh page. Issues should be gone.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label May 23, 2024
@thomasguillot thomasguillot self-assigned this May 23, 2024
@thomasguillot thomasguillot requested a review from a team as a code owner May 23, 2024 13:35
@thomasguillot thomasguillot changed the title feat: add specific gap for subscribe pattern 6 feat: add specific css for subscribe pattern 5 and 6 May 23, 2024
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 27, 2024
@thomasguillot thomasguillot merged commit f7cf899 into trunk May 28, 2024
4 checks passed
@thomasguillot thomasguillot deleted the add/subscribe-pattern-style-6 branch May 28, 2024 10:57
matticbot pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
chore(release): 1.89.0-epic-ras-acc.2 [skip ci]
137ce59 
# [1.89.0-epic-ras-acc.2](v1.89.0-epic-ras-acc.1...v1.89.0-epic-ras-acc.2) (2024-05-29)

### Bug Fixes

* dont update option on every request ([3d30e62](3d30e62))
* handle attachement fetch failure ([#2301](#2301)) ([6bdffe0](6bdffe0))

### Features

* add specific css for subscribe pattern 5 and 6 ([#2305](#2305)) ([f7cf899](f7cf899))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.89.0-epic-ras-acc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 31, 2024
@semantic-release-bot
chore(release): 1.89.0-alpha.1 [skip ci]
1eda5f7 
# [1.89.0-alpha.1](v1.88.2...v1.89.0-alpha.1) (2024-05-31)

### Bug Fixes

* handle attachement fetch failure ([#2301](#2301)) ([6bdffe0](6bdffe0))

### Features

* add specific css for subscribe pattern 5 and 6 ([#2305](#2305)) ([f7cf899](f7cf899))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.89.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jun 12, 2024
@semantic-release-bot
chore(release): 1.89.0 [skip ci]
3442d76 
# [1.89.0](v1.88.2...v1.89.0) (2024-06-12)

### Bug Fixes

* handle attachement fetch failure ([#2301](#2301)) ([6bdffe0](6bdffe0))

### Features

* add specific css for subscribe pattern 5 and 6 ([#2305](#2305)) ([f7cf899](f7cf899))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.89.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@thomasguillot thomasguillot

Labels
released on @alpha released on @epic/ras-acc released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasguillot @matticbot @adekbadek