Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure custom colours don't override newsletter modern style #2427

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: make sure custom colours don't override newsletter modern style #2427

merged 1 commit into from
Jan 20, 2025
+11 −0

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a contrast issue with the theme's checkbox styles, and the Newsletter Subscription Block's modern style -- the theme typically uses the secondary colour for the checkbox background, but the modern style always uses black. When you pick a light secondary colour, the checkmark ends up being black, which can't be seen against the black background.

See 1200550061930446-as-1208925182714392

How to test the changes in this Pull Request:

  1. Under Customizer > Custom Colours, change your secondary colour to something light.
  2. Add a Newsletter Subscription block to a post or page, and enable at least two lists.
  3. On the front end, test checking one of the lists (if they're not pre-selected), and note that you can't see the checkmark:

CleanShot 2025-01-08 at 11 14 34

  1. Apply the PR and run npm run build.
  2. Refresh the page; confirm that the checkboxes look okay:

CleanShot 2025-01-08 at 11 14 53

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 8, 2025
@laurelfulford laurelfulford requested a review from a team as a code owner January 8, 2025 19:15
dkoo
dkoo approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 20, 2025
@laurelfulford
Copy link
Contributor Author

Thanks @dkoo!

@laurelfulford laurelfulford merged commit 651b875 into trunk Jan 20, 2025
5 checks passed
@laurelfulford laurelfulford deleted the fix/newsletters-subscription-checkbox branch January 20, 2025 23:26
@github-actions GitHub Actions
Copy link

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Jan 23, 2025
@semantic-release-bot
chore(release): 2.4.3-alpha.1 [skip ci]
1cffdfa 
## [2.4.3-alpha.1](v2.4.2...v2.4.3-alpha.1) (2025-01-23)

### Bug Fixes

* make sure custom colours don't override newsletter modern style ([#2427](#2427)) ([651b875](651b875))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.3-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 3, 2025
@semantic-release-bot
chore(release): 2.4.3 [skip ci]
20b8413 
## [2.4.3](v2.4.2...v2.4.3) (2025-02-03)

### Bug Fixes

* make sure custom colours don't override newsletter modern style ([#2427](#2427)) ([651b875](651b875))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @dkoo