Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage Posts Block In Column Overflows Container If Alignment Set #774

Closed
jeffersonrabb opened this issue Feb 13, 2020 · 1 comment · Fixed by #827
Closed

Homepage Posts Block In Column Overflows Container If Alignment Set #774

jeffersonrabb opened this issue Feb 13, 2020 · 1 comment · Fixed by #827
Labels
released [Status] Has pull request [Type] Bug Incorrect behavior or functionality

Comments

@jeffersonrabb
Copy link
Contributor

Describe the bug
If a Homepage Posts block that is in a Column block has an alignment set (full|wide are the only options), it will overflow it's container and create a broken layout. This affects front end only. Editor layout remains intact. Applies only to front page or Posts with One Column Wide template.

Appears to be related to: https://github.com/Automattic/newspack-theme/blob/master/newspack-theme/sass/blocks/_blocks.scss#L53-L54

Originally flagged by @iAmSteveBeatty.

To Reproduce
Steps to reproduce the behavior:

  1. Create a multi-column layout, place Homepage Posts block in some of the columns.
  2. If testing in a Post, set template to "One Column Wide." (If testing on the frontpage no need to do this)
  3. Set the block alignment to Wide or Full, then Preview.
  4. Observe the broken layout.

Screenshots
Screen Shot 2020-02-13 at 8 29 00 AM

Expected behavior
Block is correctly constrained to the width of the column regardless of alignment.

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [Status] Has pull request [Type] Bug Incorrect behavior or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants