Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issues in where custom typography is applied #831

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a couple noticeable areas where the custom fonts aren't being applied in the themes.

It will affect all themes, though some (Nelson, Scott) need additional tweaks to make sure fonts are inheriting correctly. I'd recommend testing this with the default theme.

How to test the changes in this Pull Request:

  1. Add a navigation widget and a regular Text widget to the sidebar and footer.
  2. In a post, add an image block with a caption, and a pullquote block with a citation.
  3. Navigate to Customize > Typography, and enter two very distinct fonts to the fields -- I've been using Chalkboard and Impact, since they don't look anything like anything in the themes.
  4. Note the appearance of the following elements:
  • The text widget (compared to the navigation widget)

image

  • The comments button

image

  • The author bio link to their archives

image

  • The Pullquote citation

image

  • The image caption

image

  1. Apply the PR.
  2. Double check the above and confirm that they're using the right font (should be the one you have picked for your headers):
  • The text widget (compared to the navigation widget)

image

  • The comments button

image

  • The author bio link to their archives

image

  • The Pullquote citation

image

  • The image caption

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed Smaller PR This PR is smaller and quick to test. labels Mar 16, 2020
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. I also didn't see any areas you missed while poking around my site.

@claudiulodro claudiulodro added [Status] Approved The pull request has been reviewed and is ready to merge and removed Smaller PR This PR is smaller and quick to test. [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 17, 2020
@laurelfulford
Copy link
Contributor Author

Thanks Claudiu! 🙌

@laurelfulford laurelfulford merged commit f3d0ec8 into master Mar 17, 2020
matticbot pushed a commit that referenced this pull request Mar 17, 2020
# [1.2.0](v1.1.0...v1.2.0) (2020-03-17)

### Bug Fixes

* apply custom header color background to Newspack Nelson's footer ([04e387a](04e387a))
* correct issues in where custom typography is applied ([#831](#831)) ([f3d0ec8](f3d0ec8))
* make sure featured images are visible on pages with all templates ([346a972](346a972))

### Features

* add podigee icon to social icons svgs ([8e973a5](8e973a5))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants