Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telephone icon to social menu #849

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds a smartphone icon to the social links menu, so when you add a link to a phone number (prefixing it with tel:), it will display as a smartphone.

Closes #843

How to test the changes in this Pull Request:

  1. Apply the PR.
  2. Add a telephone number to your social links menu, prefixing with tel:
  3. Confirm that it displays as a smartphone:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed Smaller PR This PR is smaller and quick to test. labels Mar 24, 2020
@thomasguillot thomasguillot added [Status] Needs Changes or Feeback The issue or pull request needs action from the original creator and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 25, 2020
@laurelfulford
Copy link
Contributor Author

The icon has been updated and is ready for a second review! Thanks for the eyes, Thomas!

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed and removed [Status] Needs Changes or Feeback The issue or pull request needs action from the original creator labels Mar 25, 2020
Copy link
Contributor

@thomasguillot thomasguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. Thanks @laurelfulford!

@thomasguillot thomasguillot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 25, 2020
@laurelfulford
Copy link
Contributor Author

Thanks!

@laurelfulford laurelfulford merged commit 9812b28 into master Mar 25, 2020
@laurelfulford laurelfulford deleted the adds/843-telephone-icon branch March 25, 2020 16:22
matticbot pushed a commit that referenced this pull request Apr 1, 2020
# [1.4.0](v1.3.0...v1.4.0) (2020-04-01)

### Bug Fixes

* correct menu name when checking for it in header ([#859](#859)) ([b560b28](b560b28))
* CSS changed by release process ([abb4bf0](abb4bf0))
* editor color palettes and secondary color by adding full, 6-digits, hex codes ([#857](#857)) ([0c800a1](0c800a1))
* make related posts styles more consistent between formats ([#761](#761)) ([b55746d](b55746d))
* make sure social links block doesn't inherit link color ([#846](#846)) ([66c927c](66c927c))
* only apply RSS icon to /feed ([#851](#851)) ([ce884ac](ce884ac))

### Features

* add a desktop slideout widget area ([#816](#816)) ([3ed6c77](3ed6c77))
* add option to collapse comments ([#820](#820)) ([f67ab51](f67ab51))
* add telephone icon to social menu ([#849](#849)) ([9812b28](9812b28))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Smaller PR This PR is smaller and quick to test. [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Menu: Add telephone icon
3 participants