-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telephone icon to social menu #849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
added
[Status] Needs Review
The issue or pull request needs to be reviewed
Smaller PR
This PR is smaller and quick to test.
labels
Mar 24, 2020
thomasguillot
requested changes
Mar 25, 2020
thomasguillot
added
[Status] Needs Changes or Feeback
The issue or pull request needs action from the original creator
and removed
[Status] Needs Review
The issue or pull request needs to be reviewed
labels
Mar 25, 2020
The icon has been updated and is ready for a second review! Thanks for the eyes, Thomas! |
laurelfulford
added
[Status] Needs Review
The issue or pull request needs to be reviewed
and removed
[Status] Needs Changes or Feeback
The issue or pull request needs action from the original creator
labels
Mar 25, 2020
thomasguillot
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better. Thanks @laurelfulford!
thomasguillot
added
[Status] Approved
The pull request has been reviewed and is ready to merge
and removed
[Status] Needs Review
The issue or pull request needs to be reviewed
labels
Mar 25, 2020
Thanks! |
matticbot
pushed a commit
that referenced
this pull request
Apr 1, 2020
# [1.4.0](v1.3.0...v1.4.0) (2020-04-01) ### Bug Fixes * correct menu name when checking for it in header ([#859](#859)) ([b560b28](b560b28)) * CSS changed by release process ([abb4bf0](abb4bf0)) * editor color palettes and secondary color by adding full, 6-digits, hex codes ([#857](#857)) ([0c800a1](0c800a1)) * make related posts styles more consistent between formats ([#761](#761)) ([b55746d](b55746d)) * make sure social links block doesn't inherit link color ([#846](#846)) ([66c927c](66c927c)) * only apply RSS icon to /feed ([#851](#851)) ([ce884ac](ce884ac)) ### Features * add a desktop slideout widget area ([#816](#816)) ([3ed6c77](3ed6c77)) * add option to collapse comments ([#820](#820)) ([f67ab51](f67ab51)) * add telephone icon to social menu ([#849](#849)) ([9812b28](9812b28))
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
released
Smaller PR
This PR is smaller and quick to test.
[Status] Approved
The pull request has been reviewed and is ready to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR adds a smartphone icon to the social links menu, so when you add a link to a phone number (prefixing it with
tel:
), it will display as a smartphone.Closes #843
How to test the changes in this Pull Request:
tel:
Other information: