Fix editor color palettes and secondary color by adding full, 6-digits, hex codes #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasguillot
added
the
[Status] Needs Review
laurelfulford
approved these changes
Mar 30, 2020
laurelfulford
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Apr 1, 2020
# [1.4.0](v1.3.0...v1.4.0) (2020-04-01) ### Bug Fixes * correct menu name when checking for it in header ([#859](#859)) ([b560b28](b560b28)) * CSS changed by release process ([abb4bf0](abb4bf0)) * editor color palettes and secondary color by adding full, 6-digits, hex codes ([#857](#857)) ([0c800a1](0c800a1)) * make related posts styles more consistent between formats ([#761](#761)) ([b55746d](b55746d)) * make sure social links block doesn't inherit link color ([#846](#846)) ([66c927c](66c927c)) * only apply RSS icon to /feed ([#851](#851)) ([ce884ac](ce884ac)) ### Features * add a desktop slideout widget area ([#816](#816)) ([3ed6c77](3ed6c77)) * add option to collapse comments ([#820](#820)) ([f67ab51](f67ab51)) * add telephone icon to social menu ([#849](#849)) ([9812b28](9812b28))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
The function
newspack_get_color_contrast()in inc/template-functions.php requires hex codes with a 6 digits. Hex codes with 3 digits wouldn't work and we wouldn't get the correct contrast color.How to test the changes in this Pull Request:
I randomly found the issue with Newspack Popups but it can be replicated like so:
$header_color = $primary_color; $header_color_contrast = newspack_get_color_contrast( $primary_color );with$header_color = '#fff'; $header_color_contrast = newspack_get_color_contrast( '#fff' );$header_color = '#fff'; $header_color_contrast = newspack_get_color_contrast( '#fff' );to$header_color = '#ffffff'; $header_color_contrast = newspack_get_color_contrast( '#ffffff' );Other information: