Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Featured Images to RSS output #879

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Add Featured Images to RSS output #879

merged 1 commit into from
Apr 11, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

If present, add a medium-sized version of the featured image to the RSS feed.

Closes #795

How to test the changes in this Pull Request:

  1. Apply the PR.
  2. Make sure you have at least one recent post with a featured image.
  3. View the RSS feed (/feed) and confirm you see the image markup at the top of post's description and content (you can see raw RSS feeds using Chrome):

image

  1. Ideally, also check in an RSS feed reader. To do so, you'll need to test the PR on a non-localhost site, so it can pick up the feed. Please note that some RSS readers (like Feedly), will pick up the first image in a post as well, so make sure to test a post with no images in the body.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 10, 2020
@jeffersonrabb jeffersonrabb self-requested a review April 11, 2020 15:26
@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 11, 2020
@laurelfulford
Copy link
Contributor Author

Thanks Jeff!

@laurelfulford laurelfulford merged commit 8a586e3 into master Apr 11, 2020
@laurelfulford laurelfulford deleted the adds/795-featured-image-to-RSS branch April 11, 2020 19:57
matticbot pushed a commit that referenced this pull request Apr 12, 2020
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
c2193e4 
# [1.5.0](v1.4.0...v1.5.0) (2020-04-12)

### Bug Fixes

* correct fonts in latest posts block ([#878](#878)) ([ce896dd](ce896dd))
* make one column template use max px width not percentage ([#873](#873)) ([2558191](2558191))
* make sure floated pullquotes are previewing at correct width ([#876](#876)) ([cd4fed4](cd4fed4))
* style billing form to be more compact ([#868](#868)) ([c99a3fd](c99a3fd))

### Features

* add ability to turn off author bio truncation and allow HTML ([#862](#862)) ([6c6d9bf](6c6d9bf))
* add featured image to RSS output ([#879](#879)) ([8a586e3](8a586e3))
* add option to hide or toggle closed the order details ([#867](#867)) ([069cb25](069cb25))
* add support for yoast breadcrumbs ([#855](#855)) ([dfdcf28](dfdcf28))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Featured Image in RSS feeds
3 participants
@laurelfulford @matticbot @jeffersonrabb