Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump woocommerce thank you page version #910

Merged
merged 1 commit into from
May 6, 2020
Merged

Bump woocommerce thank you page version #910

merged 1 commit into from
May 6, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Right now, the thank you page version in the theme is 3.2, but the current version is 3.7, so a warning shows in the WordPress Dashboard:

image

Reviewing the WooCommerce repo, I think I managed to mangle the template version while working on theme development -- in the plugin, the thankyou.php page has been at version 3.7 since July 2019. So to fix, I just bumped the version number.

How to test the changes in this Pull Request:

  1. Activate WooCommerce.
  2. View your site's WP Dashboard and note the above WooCommerce notice.
  3. Apply the PR.
  4. Confirm that the notice is now gone.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed Smaller PR This PR is smaller and quick to test. labels Apr 30, 2020
@jeffersonrabb jeffersonrabb self-requested a review May 6, 2020 19:40
jeffersonrabb
jeffersonrabb approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slam dunk!

@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 6, 2020
@laurelfulford
Copy link
Contributor Author

Thanks Jeff!

@laurelfulford laurelfulford merged commit 1c8aa49 into master May 6, 2020
@laurelfulford laurelfulford deleted the fixes/updates-woocommerce-thankyou branch May 6, 2020 19:47
matticbot pushed a commit that referenced this pull request May 7, 2020
@semantic-release-bot
chore(release): 1.6.2 [skip ci]
c71c8b8 
## [1.6.2](v1.6.1...v1.6.2) (2020-05-07)

### Bug Fixes

* allow html in title filter ([#909](#909)) ([6fd81d0](6fd81d0))
* bump woocommerce thank you page version ([#910](#910)) ([1c8aa49](1c8aa49))
* improve custom color behavior for the button block ([#911](#911)) ([34476e5](34476e5))
* move content option fixes to block ([90e487e](90e487e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released Smaller PR This PR is smaller and quick to test. [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @jeffersonrabb