Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Template: Make sure full width blocks preview centered in editor #914

Merged
merged 1 commit into from
May 11, 2020
Merged

Default Template: Make sure full width blocks preview centered in editor #914

merged 1 commit into from
May 11, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

When a post or page is using the default template, blocks that are aligned wide and full display the same width as the rest of the posts. In the editor right now, full-width blocks are previewing at the correct width, but have the incorrect alignment.

Closes #912.

How to test the changes in this Pull Request:

  1. Create a post using the default template.
  2. Add a full-width group block and give it a background colour.
  3. Note how it looks in the editor:

image

  1. Apply the PR and run npm run build.
  2. Refresh the editor, and confirm that the full-width block is centred:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed Smaller PR This PR is smaller and quick to test. labels May 5, 2020
@jeffersonrabb jeffersonrabb added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 11, 2020
@laurelfulford
Copy link
Contributor Author

Thanks!

@laurelfulford laurelfulford merged commit e7db1d1 into master May 11, 2020
@laurelfulford laurelfulford deleted the fixes/full-width-preview branch May 11, 2020 20:09
matticbot pushed a commit that referenced this pull request May 11, 2020
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
a601c61 
# [1.7.0](v1.6.2...v1.7.0) (2020-05-11)

### Bug Fixes

* correct alignment issue with simplified header and centered logo ([#928](#928)) ([f20f1fd](f20f1fd))
* improved styling for shop and products ([7f40004](7f40004))
* make sure floated group blocks preview at 50% width ([#916](#916)) ([80580bb](80580bb))
* make sure full width blocks preview centered in editor ([#914](#914)) ([e7db1d1](e7db1d1))
* make sure the cover block gradient fills the available space ([#915](#915)) ([cc29430](cc29430))

### Features

* add option to customize copyright text ([#925](#925)) ([94961a7](94961a7))
* add simplied header option for subpages ([#901](#901)) ([ed415e5](ed415e5))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released Smaller PR This PR is smaller and quick to test. [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default template: Preview issue with full-width blocks
3 participants
@laurelfulford @matticbot @jeffersonrabb