Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Page: Make some fields more compact #868

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Right now a lot of the billing fields on the Checkout page -- Town, Province/State, Postal Code/Zip and Phone -- are 100% of the available width, when they really could be 50%.

This PR updates that to tighten things up a bit.

How to test the changes in this Pull Request:

  1. View the Checkout page (usually /checkout) on a testing site.
  2. Note the size/scale of all the fields:

image

  1. Apply the PR and run npm run build
  2. View the Checkout page, and confirm that some fields are now side-by-side:

image

Note: If you're testing with AMP enabled, the Country/Region field will also have a big button; I believe for right now we'll be disabling AMP on this page when used so it's a better customer experience, but I can circle back and address that separately if it's an issue.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 8, 2020
Copy link
Contributor

@philipjohn philipjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could definitely go further, but I think this is a worthwhile improvement.

@laurelfulford
Copy link
Contributor Author

Thanks Phil!

@laurelfulford laurelfulford merged commit c99a3fd into master Apr 9, 2020
@laurelfulford laurelfulford deleted the fixes/compact-billing-form branch April 9, 2020 18:37
matticbot pushed a commit that referenced this pull request Apr 12, 2020
# [1.5.0](v1.4.0...v1.5.0) (2020-04-12)

### Bug Fixes

* correct fonts in latest posts block ([#878](#878)) ([ce896dd](ce896dd))
* make one column template use max px width not percentage ([#873](#873)) ([2558191](2558191))
* make sure floated pullquotes are previewing at correct width ([#876](#876)) ([cd4fed4](cd4fed4))
* style billing form to be more compact ([#868](#868)) ([c99a3fd](c99a3fd))

### Features

* add ability to turn off author bio truncation and allow HTML ([#862](#862)) ([6c6d9bf](6c6d9bf))
* add featured image to RSS output ([#879](#879)) ([8a586e3](8a586e3))
* add option to hide or toggle closed the order details ([#867](#867)) ([069cb25](069cb25))
* add support for yoast breadcrumbs ([#855](#855)) ([dfdcf28](dfdcf28))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants