Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom repeat-x/y processing #2066

Closed
wants to merge 2 commits into from

Conversation

calvinsomething
Copy link
Contributor

@calvinsomething calvinsomething commented Jun 28, 2022

Fixes createPattern repetitions "repeat-x" and "repeat-y" behaving as "repeat."

It seems only fill is necessary to change, as with HTML5 canvas using stroke with either x or y options behaves the same as repeat.

Here's the visual test:
image

  • Have you updated CHANGELOG.md?

closes #2049

Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one little thing.

src/CanvasRenderingContext2d.cc Show resolved Hide resolved
@zbjornson
Copy link
Collaborator

Thanks! Landed as c6a1546 -- I ran yarn lint --fix and updated the changelog but didn't want to push to your branch without asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createPattern always uses "repeat"
2 participants