-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support toBuffer(cb, mimeType, quality)? #982
Labels
Comments
This was referenced Apr 21, 2018
Can we depend on fetch-blob to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some discussion in #743, but in essence there should be a non-streaming API for all formats with all config options (e.g. quality, PNG filter).
toBuffer(cb: function, mimeType?: string, quality?: number)
would paralleltoBlob
.Alternatively, @adamhooper proposed separate
toPNG
/toJPEG
functions.Should there be sync versions that return a value instead of accepting a callback?
See also #934 about cleaning up the PNG filter API.
I can work on this sometime soon. Feedback welcome.
The text was updated successfully, but these errors were encountered: