@stic 👋

I browsed through your PR and appreciate your approach to prevent adding new episodes (that have already been finished on another device) to up next before the sync process is complete.

Is it also to prevent auto-downloading of such episodes? It appears that episodes are added to auto-download queue only after the sync is complete:

I'm just trying to weigh in on any side effects, possibly up next not getting refreshed instantly for most users 🤔

Thanks for reviewing the PR @ashiagr
The auto-download seems to be internally checked for archived episodes, so as it happens post sync() new updates shouldn't be unnecessarily downloaded.

Indeed, a user needs to wait for sync to finish before items are added to UpNext. Personally, I'd rather have that to happen (small delay) than see episodes come and disappear (after all, the global state of me is that I've listened to these already 😉).

It's a quick fix approach, as I'm new to the project, I'm yet to see previous attempts at rationalising update & sync.
I'd suggest syncing first, building list of episodes that aren't know yet (pre-update). Then update with latest list of podcast (some might have been deleted, some added). And put back episodes where these should be.
The major issue I couldn't resolve quickly with such approach is to fetch these 'unknow' episodes on UpNext, history etc. I've come up with 'isSyncing' state, but gave up after about 7 files of changes trying to reflect new state throughout the app 😬

@stic Do you think it will fix my issue #628

@stic Do you think it will fix my issue #628

Nope @CookieyedCodes as that seems to be to order of items synced, if archived sync before starred and there is some dependency down the chain it would need a separate fix. Will have a look if no one picked that issue and it's possible to replicate (personally don't I don't star too much so haven't seen it).

Side note, is there a common approach to complex scenarios testing like this? Looked around but haven't seen anything taking sync for spin?

Ya fair enough, the sync is more so on the iOS side of things anyways,

I think most people don't touch sync because they don't want to upset users 😅

Ya fair enough, the sync is more so on the iOS side of things anyways,
I think most people don't touch sync because they don't want to upset users 😅
It's rather that the code is quite complicated (vs. complex) in this area, let me take my findings to appropriate issue ok?

Hmmm I might suggest you put it under a toggle under advanced settings then because if it does make an issue it minimizes the risk to people who do want it 🤔🤔