Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback 2024: Instagram share fix #2482

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Playback 2024: Instagram share fix #2482

merged 2 commits into from
Nov 27, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Nov 26, 2024 •
edited
Loading

📘 Part of: #2250

Fixes #2481

Apparently Instagram expects a URL for the image instead of a UIImage or NSData object. I've included this only for the Instagram app for now so we don't accidentally break something else.

To test

  • Install the app on a device with Instagram installed
  • Open Playback 2024 from Profile
  • Tap "Share this story" to share the image
  • Share to Instagram
  • Select "Story" and ensure the image is shared
  • Try the same but with other share options and apps and ensure they also work.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@bjtitus bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Nov 26, 2024
@bjtitus bjtitus requested a review from a team as a code owner November 26, 2024 20:44
@bjtitus bjtitus requested review from SergioEstevao and removed request for a team November 26, 2024 20:44
@bjtitus bjtitus changed the base branch from trunk to release/7.78 November 26, 2024 20:44
@bjtitus bjtitus added this to the 7.78 milestone Nov 26, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 26, 2024 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 7.77.1. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

SergioEstevao
SergioEstevao approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great on Instagram and the other features still working correctly

@bjtitus bjtitus changed the base branch from release/7.78 to release/7.77.1 November 27, 2024 15:29
@bjtitus bjtitus force-pushed the bjtitus/playback-2024/instagram-share-fix branch from 72875b8 to ac61034 Compare November 27, 2024 15:31
@bjtitus bjtitus modified the milestones: 7.78, 7.77.1 Nov 27, 2024
@bjtitus bjtitus merged commit e47d3d9 into release/7.77.1 Nov 27, 2024
4 of 6 checks passed
@bjtitus bjtitus deleted the bjtitus/playback-2024/instagram-share-fix branch November 27, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
[Project] End of Year 2024 End of Year project for 2024
Projects
None yet
Milestone
7.77.1
Development

Successfully merging this pull request may close these issues.

End of Year Story images are failing to share on Instagram Story
3 participants
@bjtitus @dangermattic @SergioEstevao