Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release checklist for tagging version 1.3.2.3 #68

Closed
36 of 43 tasks
benlk opened this issue Mar 2, 2020 · 2 comments
Closed
36 of 43 tasks

Release checklist for tagging version 1.3.2.3 #68

benlk opened this issue Mar 2, 2020 · 2 comments

Comments

@benlk
Copy link
Collaborator

benlk commented Mar 2, 2020

Drawing from Largo's 0.7.0 release checklist issue WPBuddy/largo#1798, the SCAMP 0.3 tag checklist INN/doubleclick-for-wp#83, Automattic/republication-tracker-tool#63, and other issues:

Team Prep Work

Before merging

The owner of the release needs to complete the following steps BEFORE merging the version-bump branch and tagging the release:

  • resolve all secret issues, private issues, or issues with the plugin that are otherwise documented outside of this public repository
  • resolve all GitHub maintainer security advisories: merge and publish.
  • update and sort the changelog
    • make sure changelog has all items from this release, and all PRs and issues are linked
    • check that ordering and grouping of items is logical.
    • New features list
    • Dev-facing updates
    • Bugfixes
    • Potentially breaking changes and upgrade notices
    • Which versions of PHP was this tested against? (why) List the PHP versions that we're sure of and that WordPress supports. (See Travis updates: drop PHP 7.0, add 7.2 and 7.3 WPBuddy/largo#1801)
  • update description
    • in readme.txt
    • in plugin description comment
  • bump version number
    • in readme.txt
    • in pym-shortcode.php
    • in readme.md
    • in docs/maintainer-notes.md
  • testing as described in https://github.com/INN/pym-shortcode/blob/master/docs/maintainer-notes.md

Release process

After release is published

  • update plugins on our sites (inndev? ccs?)
  • publish update announcement blog post
  • tweet announcement and schedule 2-5 for the next 7 days (via TweetDeck, HootSuite, or similar) with simple download prompt or tweets detailing new features, like "Newsroom Staff Pages should be clean and useful. We think so too. See Largo 0.X's new...." Make sure these tweets get cross-tweeted between INN accounts.
  • add to Nerd Alert for following week
  • create the release ticket for the next milestone from this one -> Release checklist for tagging version 1.3.2.4 #71
  • prune stale and merged branches
  • notify maintainers of related plugins: News Project, WP AMP
@benlk
Copy link
Collaborator Author

benlk commented Mar 2, 2020

Testing without AMP:

Plugin settings:

  • Does the plugin settings page work?

Shortcode tests:

  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymoptions=" xdomain: '\\*\.npr\.org' "]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" class="one two three four float-left mw_50"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align=""]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="none"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="left"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="center"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="right"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="wide"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" align="full"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" id="extremely_specific_id"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions="xdomain: '\\*\.npr\.org'"]
  • [pym src="https://blog.apps.npr.org/pym.js/examples/table/child.html" pymsrc="https://pym.nprapps.org/pym.v1.min.js" pymoptions=""]

Gutenberg tests:

  • the block, when inserted, prompts users for a URL
  • the block's alignment, custom classes, custom ID, and other options are respected.
  • the block uses the default pymsrc URL if the pymsrc attribute is not set
  • on a site with Gutenberg not installed, the plugin functions
  • on a 4.9 site with Gutenberg installed, the plugin functions
  • on a 5.0 site, the plugin functions

@benlk
Copy link
Collaborator Author

benlk commented Mar 2, 2020

AMP testing was sufficiently covered during #62, so I'm skipping that for this issue.

@benlk benlk mentioned this issue Mar 3, 2020
2 tasks
@benlk benlk closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant