Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module lesson order updates not persisted with object cache #3891

Closed
yscik opened this issue Jan 14, 2021 · 3 comments · Fixed by #4236
Closed

Module lesson order updates not persisted with object cache #3891

yscik opened this issue Jan 14, 2021 · 3 comments · Fixed by #4236
Labels
Milestone

Comments

@yscik
Copy link
Contributor

yscik commented Jan 14, 2021

Steps to Reproduce

  • Set up an object cache plugin / Jetpack / Atomic
  • Create a course with modules and lessons in a module
  • Reorder the lessons inside a module, either in the course outline block, or the Lesson order admin page

What I Expected

  • The changed order to persist

What Happened Instead

  • The original order is restored after saving
  • After refresh the page a few seconds later, the changed order is now applied

PHP / WordPress / Sensei LMS version

  • Sensei LMS 3.6.1

Screenshot / Video

Screen.Recording.2021-01-14.at.14.16.21.mov
@yscik
Copy link
Contributor Author

yscik commented Jan 14, 2021

The root of the problem is that this meta is stored on the lesson posts (_order_module_XXX). Top-level lesson and module order, which is stored on the course post that's being updated, is not affected.

@donnapep
Copy link
Collaborator

donnapep commented Mar 1, 2021

Was able to reproduce this on a Pressable site. Noting here that refreshing the page after reordering only shows the updated order when using the course outline block, but not when reordering and refreshing the Order Lessons page.

Setting as high priority because I've seen some complaints of this myself, and because reordering doesn't work at all on the Order Lessons page.

@donnapep donnapep changed the title Module lesson order update delayed with object cache Module lesson order updates not persisted with object cache Mar 1, 2021
@cagrimmett
Copy link

Ran into this as well:

  • Reordered the lessons
  • Saved
  • Page refresh
  • Not honoring saved reordering
  • Flushed object cache through Pressable control panel
  • Refreshed lesson order page
  • Showed the correct ordering we saved originally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants