Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to customize Lesson Actions buttons in Learning Mode #7088

Closed
donnapep opened this issue Aug 11, 2023 · 8 comments · Fixed by #7224 or #7283
Closed

Unable to customize Lesson Actions buttons in Learning Mode #7088

donnapep opened this issue Aug 11, 2023 · 8 comments · Fixed by #7224 or #7283
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Learning Mode [Pri] Normal Can wait for the next release [Type] Bug
Milestone

Comments

@donnapep
Copy link
Collaborator

donnapep commented Aug 11, 2023

We have had multiple reports of users wanting to customize the colors of the Complete Lesson and Take Quiz buttons, but they are unable to. This has been reported for the Divi, Kadence and GeneratePress themes.

Steps to Reproduce

  1. Activate a non-block theme like Divi.
  2. Open the Lesson (Learning Mode - Default) template in the site editor.
  3. Click on the Lesson Actions block.
  4. Customize each of the block settings.

What I Expected

The block settings to be applied correctly.

What Happened Instead

The block settings are applied inconsistently. For example, when updating the colors, only the background color of the Complete Lesson button changes, but the text does not. The style of the Take Quiz button does not change at all. Typography settings have no effect.

I dug into this a bit and here are some solutions I considered:

  • Make global styles work for buttons on non-block themes. Although we should still try to do this, setting it globally would mean updating button styles across the entire site, which isn't ideal.
  • Adding button text and background colors to the customizer. I also dismissed this idea because ultimately we want people to make customizations in a single place - the site editor.

Where I ultimately landed was that the best solution may be to either create a new block or add a deprecation for the existing one (preferred). The new / updated block would use the existing core button block so that we can leverage its settings. It would be a bonus if we could somehow reuse the existing Lesson Actions block that we use when Learning Mode is disabled.

However, we would need to take care to not break the template. If we used the deprecation approach, this shouldn't be an issue.

Other ideas are also welcome!

Screenshot / Video

Screenshot 2023-08-11 at 8 15 12 AM

Context / Source

6629803-zd-a8c
6625413-zd-a8c
6529340-zd-a8c

@donnapep donnapep added [Type] Bug [Pri] Normal Can wait for the next release Learning Mode labels Aug 11, 2023
@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6629803-zen
  • 6625413-zen
  • 6529340-zen
  • 6662212-zen
  • 6734841-zen
  • 6656963-zen
  • 6771547-zen
  • 7113694-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 11, 2023
@donnapep donnapep added [Project] Frontend Improvements and removed Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Aug 11, 2023
@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 11, 2023
@StefMattana
Copy link

+1 6662212-zen

@renatho
Copy link
Contributor

renatho commented Aug 28, 2023

+1 6734841-zd-a8c

@renatho
Copy link
Contributor

renatho commented Aug 28, 2023

The new / updated block would use the existing core button block so that we can leverage its settings.

+1 for this approach. I imagine it's the best one in order to be more compatible, using a more native solution.
A good reference is this one implemented by Donna.

@Imran92 Imran92 self-assigned this Sep 1, 2023
@renatho
Copy link
Contributor

renatho commented Sep 1, 2023

+1 6656963-zd-a8c

@StefMattana
Copy link

Another one reported 6771547-zen

The user would like to change the colour also of the progress button.

@jom
Copy link
Member

jom commented Sep 8, 2023

Another report 6662212-zd-a8c

They would also like to customize the Next / Previous buttons.

@StefMattana
Copy link

+1 7113694-zen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Learning Mode [Pri] Normal Can wait for the next release [Type] Bug
Projects
None yet
5 participants