Create quiz progress on quiz answers submit

[merkushin]

Resolves #7050

We create the quiz progress when start the lesson. When the user submits their answers we implicitly start the lesson.
Here we make sure we have a quiz progress or try to create one.
We don't check the feature flag as it is safe to create quiz progress for comments-based version: it is the same lesson progress there.

Proposed Changes

• Create quiz progress on lesson progress creation if there is a quiz related to the lesson.

Testing Instructions

1. Enable tables_based_progress.
2. Start a lesson (or go directly to a quiz and submit your answers).
3. Check sensei_lms_progress has quiz progress for the quiz. In case it was created on the lesson start in-progress status expected, on the quiz answers submit depends on quiz settings: could be ungraded, passed, failed, graded.

Pre-Merge Checklist

• PR title and description contain sufficient detail and accurately describe the changes
• Acceptance criteria is met
• Decisions are publicly documented
• Adheres to coding standards (PHP, JavaScript, CSS, HTML)
• All strings are translatable (without concatenation, handles plurals)
• Follows our naming conventions (P6rkRX-4oA-p2)
• Hooks (p6rkRX-1uS-p2) and functions are documented
• New UIs are responsive and use a mobile-first approach
• New UIs match the designs
• Different user privileges (admin, teacher, subscriber) are tested as appropriate
• Code is tested on the minimum supported PHP and WordPress versions
• User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
• "Needs Documentation" label is added if this change requires updates to documentation
• Known issues are created as new GitHub issues

[codecov]

Codecov Report

Merging #7136 (12f016a) into trunk (05932d8) will increase coverage by 0.13%.
Report is 23 commits behind head on trunk.
The diff coverage is 87.61%.

@@             Coverage Diff              @@
##              trunk    #7136      +/-   ##
============================================
+ Coverage     49.36%   49.50%   +0.13%     
- Complexity    10546    10582      +36     
============================================
  Files           575      578       +3     
  Lines         44537    44629      +92     
  Branches        402      402              
============================================
+ Hits          21987    22092     +105     
+ Misses        22223    22210      -13     
  Partials        327      327              

Files Changed	Coverage Δ
...d-jobs/class-sensei-scheduler-action-scheduler.php	83.33% <0.00%> (ø)
includes/class-sensei-utils.php	52.44% <ø> (ø)
includes/class-sensei.php	23.14% <0.00%> (-0.28%)	⬇️
includes/class-sensei-quiz.php	59.40% <69.56%> (+0.27%)	⬆️
...ternal/action-scheduler/class-action-scheduler.php	100.00% <100.00%> (ø)
...er/migrations/class-student-progress-migration.php	81.63% <100.00%> (+0.73%)	⬆️
...nt-progress/jobs/class-migration-job-scheduler.php	100.00% <100.00%> (ø)
...rnal/student-progress/jobs/class-migration-job.php	100.00% <100.00%> (ø)
...itories/class-quiz-progress-repository-factory.php	100.00% <100.00%> (ø)
...al/student-progress/tools/class-migration-tool.php	100.00% <100.00%> (+68.96%)	⬆️

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc6e89...12f016a. Read the comment docs.

[merkushin]

We had lots of errors like Undefined function Sensei(). I encountered it in this PR as well.
It looks like Psalm for some reason can't discover some entities via reflection. In these cases, I found a recommendation, put files containing those entities into <stubs>.
Another approach might be to create config/psalm/psalm-stubs.php and define functions like Sensei() there (without implementation) and include these stubs in config like I did with above.

[m1r0]

Hm, I wasn't able to reproduce this.

I've tried to create a fresh course with a lesson and a quiz. After taking the course and the quiz, it didn't create a quiz progress entry. Did I do something wrong?

QUZkUE.mp4

[merkushin]

@m1r0 you're right, my bad. Found a few issues. Looks like I tested on stale data.
Fixed it here: ee6a628

[m1r0]

Thanks, I see the quiz progress but it is added even if the lesson doesn't have a quiz. Is that expected?

iHLs69.mp4

[merkushin]

Thanks @m1r0.
I updated the PR to take into account only published quizzes.
However, I'm still puzzled with a question when the publishing happens.

[m1r0]

Nice! Now it creates the quiz progress only when there is a quiz for that lesson. Related to that, does it make more sense to create the quiz progress when you open the quiz itself, similar to how the progress works for lessons?

On a side note, psalm and the linter are failing.

[merkushin]

Related to that, does it make more sense to create the quiz progress when you open the quiz itself, similar to how the progress works for lessons?

Makes sense for me. Updated here: fc2bad4

I removed creation of the quiz progress from the lesson starting function as it leads to a conflict.

[m1r0]

Nice! 💯