Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice on lesson report #7631

Closed
donnapep opened this issue Jul 18, 2024 · 1 comment
Closed

Deprecation notice on lesson report #7631

donnapep opened this issue Jul 18, 2024 · 1 comment
Assignees
Labels
[Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug

Comments

@donnapep
Copy link
Collaborator

donnapep commented Jul 18, 2024

Steps to Reproduce

  1. Enable define( 'WP_DEBUG_DISPLAY', true ); in wp-config.php.
  2. Go to the Students taking this Lesson report (wp-admin/admin.php?page=sensei_reports&lesson_id=<lesson_id>).
  3. See deprecation notice*.
  4. Export the rows.

*Note that this only happened for some lessons; other lessons were fine. I noticed that I only saw the deprecation message when more than 2 students had taken the lesson, but the cause could be something else. So this may take a bit of digging / testing different scenarios. See screenshots below.

What I Expected

No deprecation notice and the rows to export without issue.

What Happened Instead

The following deprecation notice is displayed:

PHP Deprecated:  preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in /Users/donnapep/Local Sites/senseitheme/app/public/wp-includes/kses.php on line 1805

The export looks like this:

Screenshot 2024-07-18 at 3 40 33 PM

Screenshots

Screenshot 2024-07-18 at 3 48 06 PM

Screenshot 2024-07-18 at 3 48 33 PM

Screenshot 2024-07-18 at 3 52 56 PM

@donnapep donnapep added [Type] Bug [Status] Triaged Issue has been triaged labels Jul 18, 2024
@donnapep donnapep added this to the 4.24.2 milestone Jul 18, 2024
@donnapep donnapep added the [Pri] Normal Can wait for the next release label Jul 18, 2024
@merkushin merkushin self-assigned this Aug 2, 2024
@merkushin
Copy link
Member

@m1r0 addressed this issue in #7644

Can't reproduce it anymore.

@donnapep donnapep removed this from the 4.24.2 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged [Type] Bug
Projects
None yet
Development

No branches or pull requests

2 participants